release 0.3.4 #135
Merged
release 0.3.4 #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chfw
commented
Nov 18, 2018
chfw
commented
- support moban-handlebars and any other extensions
- support ✨ Add new target and template global variables #125
This adds new global variables for the target and template files. Closes #29
✨ Add new target and template global variables
📚 Update changelog
* 🔨 code refactoring * 🔨 format code * 🔨 pump up the version * 💚 fix the problem with the import. mysteriously, moban.extensions works but relocating it to moban.jinja2.extension wont do * 🔨 code refactoring * ✨ code refactoring * 🔨 code refactoring on jinja2 engine * 🔨 code refactoring * 🔨 load handle_bar by default for now * 💚 include pybars3 as temp requirements to pass unit tests * 🐛 fix a typo * 🔨 allow base engine to have constructor that has more shared code * :tructor: rename engine_factory * 🔨 code refactor jinja2 engine * 🔥 remove duplicated find template file * 🔥 remove useless function * 🔥 remove logging
…ny to come (#131) * 🔨 clarify engine interface * 🔨 minor tuning * 🔥 strip the extra responsibility from engine: 1) is there a change 2) where is the template on file system. * 💄 format code * 🔥 remove if py2 do something else do others for open. because codecs is python 2 and 3 compactible * :sparles: test the handle bar engine separately. it will be easy for up-coming separation * 🔥 remove useless proxy function * 💄 code formatting * :micrscope: test newly create class interfaces * 🔥 label output is not used for handlebar engine * 📚 document engine interface * 💚 make flake8 happy on the coding style
* 🔨 further optimization. all jinja2 related code should go in jinja2 folder * 🚜 all jinja2 extensions shall live in jinja2 folder. * :micrscope: add jinja2 extensions test * 💚 keep two stage lml loading. Althrough it is not yet understood why, it works. * 🐛 fix loading bug. otherwise, Error: jinja2 * 📚 make notes on critical code lines
* 🔥 separate handlebars to moban-handlebars * 🐛 fix get_primary_key will fail when a module is loaded later. fix #8. and remove pybars3 * 📚 update handlebars usage * 🐛 moban hash does not work because trailing new line was not removed when the hash is calculated but is removed when saving the files. hence moban think the file is always updated. 🔥 remove engine handlebars loading * 📚 update conf.py from pypi-mobans-pkg * 💚 use moban-handlebars git repo for testing * 📚 update change log, docs and correct typepos
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
- Coverage 98.57% 98.44% -0.14%
==========================================
Files 38 39 +1
Lines 1896 1800 -96
==========================================
- Hits 1869 1772 -97
- Misses 27 28 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.