Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Sep 14, 2019

Before raising the PR, here is a check list:

  • have you written unit tests for your code changes?
  • have you updated the change log?
  • can someone else understand your changes without your explanation?
  • are you proud of your code changes?
  • please add your name and github link to contributors.rst in alphabetical order.

* prototype

* ✨ nice add-on for implicit target syntax. resolves #322

* 👕 update coding style

* 📚 update change log and pump up version number
…sion' (#332)

* ✨ support cli option -e, user defined extension. resolves #257

* 🐛 update code

* ✨ support cli extensions. #257

* 💚 updated broken tests

* 🔥 take the test for now

* 👕 update coding style

* 🔬 add test case

* 📚 update change log

* 🔥 do not test -e on python 2 because 3rd party extension does not work on python 2, which is not an issue beyond 2020

* 🐛 check jj2, alias of jinja2 works too

* 👕 code style and variable name update

* 📚 prepare for release
@chfw chfw requested review from ayan-b and jayvdb September 14, 2019 08:48
@codecov-io
Copy link

codecov-io commented Sep 14, 2019

Codecov Report

Merging #334 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
+ Coverage   95.36%   95.58%   +0.22%     
==========================================
  Files          51       51              
  Lines        2547     2584      +37     
==========================================
+ Hits         2429     2470      +41     
+ Misses        118      114       -4
Impacted Files Coverage Δ
tests/test_docs.py 100% <ø> (ø) ⬆️
moban/_version.py 100% <100%> (ø) ⬆️
...sts/integration_tests/test_command_line_options.py 100% <100%> (ø) ⬆️
moban/definitions.py 100% <100%> (ø) ⬆️
moban/mobanfile/templates.py 100% <100%> (ø) ⬆️
moban/jinja2/engine.py 98.8% <100%> (+0.05%) ⬆️
moban/constants.py 100% <100%> (ø) ⬆️
moban/core/moban_factory.py 92.76% <100%> (+3.17%) ⬆️
moban/main.py 99.2% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4427533...692086a. Read the comment docs.

@chfw chfw merged commit 566384a into master Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants