feat(adapters): add GPU correctness evidence - #137
Merged
Conversation
Owner
Author
morluto
marked this pull request as ready for review
August 9, 2026 21:13
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb0a5adff8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Flameox can preserve trial verdicts and benchmark samples, but it could not retain bounded per-case numerical evidence for GPU kernel validation or collect NVIDIA Compute Sanitizer findings as first-class evidence.
This PR adds those two correctness layers while keeping the upstream tools authoritative.
Relates to #131.
Relates to #135.
Approach
flameox.kernel-validation.v1contract, publish its generated JSON Schema, and extract case/output identities and declared metrics into additive Parquet tables.compute-sanitizerCLI with closed options, fixed XML output, bounded isolated parsing, and preservation of stdout, stderr, reports, and failed attempts.Suggested review order:
src/flameox/adapters/kernel_validation.pyand the published schemasrc/flameox/adapters/compute_sanitizer.pyand its workerCommands run
The collection receipt covers 923 node IDs across 84 files. Both import-boundary contracts pass, and generated-schema regeneration leaves no diff.
Compatibility
The evidence schema advances additively from 1.8 to 1.9. Historical generations receive typed empty validation views and are not rewritten.
Compute Sanitizer capture requires the official NVIDIA executable and a compatible CUDA GPU. Deterministic fixtures cover clean, malformed, truncated, unknown, and bounded-report behavior; the local provider lane also passed clean and intentional out-of-bounds kernels. GitHub-hosted CI runs the fixture and simulated-process coverage and does not schedule a GPU lane that could pass only by skipping.