feat(adapters): add GPU profiling and trace evidence - #139
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c663bd57a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
6d0d788 to
235851b
Compare
c663bd5 to
c72db89
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c72db89281
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Description
Flameox can preserve accelerator timelines, but it lacked bounded per-kernel hardware evidence from Nsight Compute and a managed ROCm PFTrace capture path. Users therefore had to translate reports manually or run rocprofv3 outside the evidence chain.
This stacked PR adds official-interface Nsight Compute extraction and rocprofv3 PFTrace capture through the existing Perfetto route. It is based on #138; after the preceding PRs merge, this branch can be retargeted to
main.Relates to #133.
Relates to #136.
Approach
.ncu-repand.ncu-repzunchanged and extract through thencu_reportinterface shipped with the detected Nsight Compute installation. Flameox does not decode NVIDIA report binaries or add a runtime PyPI substitute.ncucapture selection and separate capability reporting for executable/interface availability and counter permission.ERR_NVGPUCTRPERMmaps to actionablepermission_required; unrelated nonzero probes degrade instead of advertising availability.Suggested review order:
src/flameox/adapters/nsight_compute.pyand its isolated workerCommands run
The final collection receipt covers 1,029 node IDs across 95 files. Both import-boundary contracts pass.
Compatibility
Nsight Compute extraction requires its official Python report interface. Successful live counter capture and extraction ran locally with Nsight Compute 2026.2.1 after administrator-enabled NVIDIA performance-counter access. Flameox never changes host privileges.
No AMD host was available. rocprofv3 command construction, domain selection, partial-output preservation, and failures are covered by deterministic process fixtures. A project-owned ROCm-shaped Perfetto trace exercises import → existing Perfetto extraction → accelerator summary, but it is explicitly not vendor-produced PFTrace and does not prove native rocprofv3 format compatibility. A genuine trace with recorded provenance and redistribution permission remains the hardware proof gap. GitHub-hosted CI does not schedule GPU-only jobs that could pass by skipping.