fix: harden setup, MCP, and external boundary contracts#107
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Twenty open issues exposed inconsistent validation and diagnostics at capability boundaries. Schema limits were not always enforced at runtime, setup could discover corpus blockers after planning other work, and several adapters collapsed distinct failure states.
This change aligns those contracts:
Key invariants:
No corpus schema, dependency, or public third-party type changes are included.
Suggested review order
internal/app/mcp_scalable_operations.go,internal/app/sync_headers.go, andinternal/mcpserver/scalable.go.internal/app/setup.goand the CLI diagnostics.Testing Done
go test ./...go vet ./...golangci-lint run --timeout=5m --new-from-rev=origin/main(0 issues)go test -race ./internal/github ./internal/appgo test -race ./internal/corpusnpm run test:npm(4 tests)npm run test:e2e(5 tests)npm pack --dry-rungo mod tidy(no diff)Checklist
gofmtapplied to changed Go files.Closes #87
Closes #88
Closes #89
Closes #90
Closes #91
Closes #92
Closes #93
Closes #94
Closes #95
Closes #96
Closes #97
Closes #98
Closes #99
Closes #100
Closes #101
Closes #102
Closes #103
Closes #104
Closes #105
Closes #106