feat(commitplan): add hunk-aware semantic commit planning - #121
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contribution preparation could summarize changed files, but it could not represent two independent changes in one file or prove that a proposed commit split covered the exact workspace patch.
This adds a read-only two-step planning contract:
The deterministic layer verifies one-to-one coverage, duplicate or missing assignments, dependency references and cycles, conventional commit subjects, metadata bounds, untracked-file ownership, and reconstruction digests. It reports generated, binary, rename/copy, whitespace-only, and untracked changes as explicit warnings. Semantic intent remains an agent/human judgment; the tool does not infer commit meaning, stage files, or rewrite history.
Unified-diff parsing uses the maintained
sourcegraph/go-diffpackage instead of a custom parser. Workspace collection uses bounded, non-mutating Git reads and identifies untracked content by Git object ID without persisting file bodies.MCP exposes separate inspect and build tools so an agent can freeze the patch before proposing groups and detect changes between those steps.
Closes #116.
Suggested review order
internal/commitplan/planner.goand tests for parsing, unit identity, coverage, and dependency rules.internal/workspace/workspace.gofor bounded patch/untracked inventory.Testing
make verifyCompatibility and scope
The planner is advisory and read-only. Existing commit preparation remains unchanged.