fix: avoid Bun file IO in morph_edit#30
Open
fengjikui wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #29.
morph_editnow uses Nodefs/promisesfor local file reads and writes instead ofBun.file/Bun.write. This keeps the Morph SDK calls, tool names, WarpGrep tools, and compaction hooks unchanged while allowing the plugin to run in OpenCode Desktop / Node-style plugin runtimes that do not expose a globalBunobject.Root cause
The plugin is built as a JavaScript package for OpenCode, but the
morph_editimplementation directly referenced Bun runtime globals for file IO. In OpenCode Desktop, the plugin can execute in an Electron/Node environment whereBunis not defined, somorph_editcould fail before reaching the Morph API.Changes
Bun.file(...).text()withreadFile(..., "utf8").Bun.write(...)withwriteFile(..., "utf8").morph_editfile IO from reintroducingBun.file/Bun.write.Validation
bun test index.test.ts -t 'morph_edit'bun testbun run typecheckbun run buildbun run cinpm pack --dry-rungit diff --check