Skip to content

ci(release): trigger update-image-tag + drop npm publishing#114

Merged
rguichard merged 1 commit into
morpho-mainfrom
ci/trigger-update-image-tag
Jul 10, 2026
Merged

ci(release): trigger update-image-tag + drop npm publishing#114
rguichard merged 1 commit into
morpho-mainfrom
ci/trigger-update-image-tag

Conversation

@rguichard

@rguichard rguichard commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

Two release-workflow adjustments for the morpho-org/erpc fork:

  1. Trigger update-image-tag after a successful Docker push — a new release now automatically opens the chart image-tag bump PR.
  2. Drop npm publishing — the fork doesn't own the upstream npm packages, so those steps always failed.

Changes

1. New update job (dispatch update-image-tag.yaml)

  • needs: [docker-manifest] and if: push && tag — runs only after a successful Docker build+push. It does not depend on the GoReleaser release job.
  • Dispatches update-image-tag.yaml (on morpho-main) via actions/github-script@v7 + github.rest.actions.createWorkflowDispatch, using the workflow GITHUB_TOKEN with permissions: { actions: write, contents: read } (workflow_dispatch is the documented exception that lets GITHUB_TOKEN start another workflow — no App token needed).
  • Inputs: version_tag (validated semver from the release tag) and release_url derived from the triggering release tag, not from the release job.
  • Mirrors the update job in morpho-org/morpho-api (.github/workflows/push.yml) for long-term maintainability.

2. Remove npm publishing

  • morpho-org/erpc is a fork of erpc/erpc and does not own @erpc-cloud/cli, erpc, start-rpc, start-erpc, @erpc-cloud/config (npm returns E404 on PUT for unauthorized publishes; no NPM_TOKEN is configured either).
  • Removed the pnpm/Node setup, the five publish steps, and the "Verify packages are live on npm" step from the release job.
  • Deleted the now-unused .github/scripts/publish-npm.sh.
  • The fork consumes erpc via Docker only, so npm distribution isn't needed.

Testing

  • release.yml validated as well-formed YAML.
  • The update job already ran green on release 0.1.6 (run 29079819595) and dispatched update-image-tag.yaml; that same run's failure was the npm publish step this PR removes.

Notes

  • The prepare-release job (workflow_dispatch path) still bumps package.json versions and generates CLI release files. It doesn't publish, so it doesn't fail — left as-is. Can be trimmed in a follow-up if the fork wants npm gone entirely.

Add an `update` job to release.yml that dispatches the local
update-image-tag.yaml workflow once the multi-arch images are published,
mirroring the `update` job in morpho-org/morpho-api (push.yml):
github-script + createWorkflowDispatch via the workflow GITHUB_TOKEN
(actions: write).

It depends only on docker-manifest, so a failing GoReleaser/npm
`release` job never blocks deployment. The release_url is derived from
the tag that triggered the workflow, not from the release job.
@rguichard rguichard requested a review from 0x666c6f as a code owner July 9, 2026 14:51
@rguichard rguichard self-assigned this Jul 9, 2026
@rguichard rguichard merged commit 99fece8 into morpho-main Jul 10, 2026
12 checks passed
@rguichard rguichard changed the title ci(release): trigger update-image-tag after docker push ci(release): trigger update-image-tag + drop npm publishing Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants