[Certora] Only authorized users can decrease the share of a lender#410
Merged
Conversation
QGarchery
reviewed
Feb 26, 2026
lilCertora
changed the title
lilCertora
changed the title
lilCertora
changed the title
…ed-decrease-shares
…ed-decrease-shares
QGarchery
reviewed
Mar 5, 2026
…ed-decrease-shares
lilCertora
force-pushed
the
certora/only-authorized-decrease-shares
branch
from
adee165 to
dc54ad2
Compare
QGarchery
reviewed
Mar 6, 2026
Co-authored-by: Quentin Garchery <garchery.quentin@gmail.com> Signed-off-by: lilCertora <lilian@certora.com>
Co-authored-by: Quentin Garchery <garchery.quentin@gmail.com> Signed-off-by: lilCertora <lilian@certora.com>
Co-authored-by: Quentin Garchery <garchery.quentin@gmail.com> Signed-off-by: lilCertora <lilian@certora.com>
Co-authored-by: Quentin Garchery <garchery.quentin@gmail.com> Signed-off-by: lilCertora <lilian@certora.com>
Co-authored-by: Quentin Garchery <garchery.quentin@gmail.com> Signed-off-by: lilCertora <lilian@certora.com>
QGarchery
approved these changes
Mar 6, 2026
jhoenicke
approved these changes
Mar 8, 2026
jhoenicke
left a comment
jhoenicke
left a comment
Collaborator
There was a problem hiding this comment.
Looks fine.
I'm wondering about the @withrevert in take. You could just write it without and then assert !takerUnauthorized. This is probably a minor thing. It is interesting that it still works to assert that sharesAfter/sharesBefore behave like this, but I guess the prover knows that for a revert the shares don't change.
bhargavbh
approved these changes
Mar 9, 2026
MathisGD
reviewed
Mar 9, 2026
Collaborator
There was a problem hiding this comment.
after #473, this can become OnlyAuthorizedCanChangeShares
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only authorized users can decrease the share of a lender.
last run