docs(market-making): separate architecture documentation - #121
Merged
Conversation
julien-devatom
marked this pull request as ready for review
August 4, 2026 08:53
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49ed44fc0d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
haydenshively
added a commit
that referenced
this pull request
Aug 5, 2026
main gained #121/#124/#125 after this branch's merge-base, which is why GitHub reported the stack as conflicting and suppressed its checks entirely — the mergeability of a stacked PR is computed against main, not the immediate parent. This is the "six open PRs add new bun:test files and Bun.* calls" follow-up the PR body anticipated, now due for the three that merged. Applied the same mechanical port to what main brought in: - 8 test files from bun:test to vitest (`mock()` -> `vi.fn()`), plus 2 more where 130 had already converted the import and main added new `mock(` sites - Bun.file -> readFile, Bun.serve -> the node:http adapter this branch already uses, Bun.sleep -> node:timers/promises, in the setup-state test - 3 more floating `expect(...).rejects` awaited — the same latent bug class this branch documents, arriving from main where bun's typings still hid them Verified: 1459 pass / 1 skip / 141 files, zero failures; vitest collects exactly the 141 tracked *.test.ts files (diffed, zero delta); pnpm lint 0/0; knip clean; 12/12 typecheck; jsdoc:build exits 0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
haydenshively
added a commit
that referenced
this pull request
Aug 7, 2026
main gained #121/#124/#125 after this branch's merge-base, adding test files that still import bun:test and call bun's mock(). Linearizing the stack dropped these conversions along with the merge commit that carried them, so they are restored here as their own commit: 7 files moved to vitest imports and mock() -> vi.fn(). Tree is byte-identical to the verified pre-rebase state. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
haydenshively
added a commit
that referenced
this pull request
Aug 7, 2026
main gained #121/#124/#125 after this branch's merge-base, adding test files that still import bun:test and call bun's mock(). Linearizing the stack dropped these conversions along with the merge commit that carried them, so they are restored here as their own commit: 7 files moved to vitest imports and mock() -> vi.fn(). Tree is byte-identical to the verified pre-rebase state. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
haydenshively
added a commit
that referenced
this pull request
Aug 7, 2026
main gained #121/#124/#125 after this branch's merge-base, adding test files that still import bun:test and call bun's mock(). Linearizing the stack dropped these conversions along with the merge commit that carried them, so they are restored here as their own commit: 7 files moved to vitest imports and mock() -> vi.fn(). Tree is byte-identical to the verified pre-rebase state. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/architecture.mdValidation
bun run --filter @morpho-org/market-making-bot typecheckbun lintbun formatbun testwith the local archive RPC mapped toRPC_URL_8453(1380 passed, 3 skipped)