Merged
Conversation
# Description Add retry logic to create_run # Issues Fixed Tests failed here because create_run timed out https://github.com/mosaicml/composer/actions/runs/11452297889/job/31901019192#step:3:348 Adding a retry should help
j316chuck
requested review from
b-chu and
snarayan21
and removed request for
snarayan21
snarayan21
reviewed
Nov 13, 2024
snarayan21
left a comment
snarayan21
left a comment
There was a problem hiding this comment.
should we just increase timeout? i don't mind either way, up to @b-chu
Contributor
|
I think it's better to increase timeout in |
Contributor
Author
|
bumped timeout to 30 seconds. for corgi the retry def helped a lot for stability so i think we should keep wdyt? this new logic will max increase latency by 2 minutes which is an appropriate tradeoff? |
Contributor
|
Let's just do timeout for now and if run creation keeps timing out, we can add backoff later |
added 2 commits
November 14, 2024 10:06
Contributor
Author
|
sounds good fixed |
b-chu
approved these changes
Nov 14, 2024
Contributor
b-chu
left a comment
b-chu
left a comment
There was a problem hiding this comment.
Untested but Chuck said he'd fix if there's any issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add retry logic to create_run
Issues Fixed
Tests failed here because create_run timed out
https://github.com/mosaicml/composer/actions/runs/11452297889/job/31901019192#step:3:348
Adding a retry here should help