Skip to content

fix(approvals): preserve first concurrent resolution - #101

Merged
ralyodio merged 1 commit into
moshcoder:mainfrom
rissrice2105-agent:fix/approval-resolution-race
Jul 31, 2026
Merged

fix(approvals): preserve first concurrent resolution#101
ralyodio merged 1 commit into
moshcoder:mainfrom
rissrice2105-agent:fix/approval-resolution-race

Conversation

@rissrice2105-agent

Copy link
Copy Markdown
Contributor

Summary

  • make the approval transition out of pending conditional in the update itself
  • preserve the first submit/kill decision when concurrent requests read the same pending row
  • add a deterministic integration regression that reproduces the interleaving

Validation

  • focused approval-resolution regression: 1/1 passed
  • complete PWA suite: 115/115 passed
  • full repository suite: 365 passed, 5 skipped; the remaining 7 failures are pre-existing POSIX shell/signal assertions on Windows
  • syntax checks and git diff --check passed

Closes #100

@ralyodio
ralyodio merged commit fe246a2 into moshcoder:main Jul 31, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Concurrent approval resolutions can overwrite the first decision

2 participants