pit: $2 a name, $5 an ending — no trailing cents - #144
Merged
Conversation
PRD 0005 §10.1 wrote these as $1.99 and $4.99. The extra cent buys nothing but a price tag shaped like a supermarket shelf, and every number here is one a person has to reason about: a default, a ceiling, a per-line override. Round. Which price is which mattered and was easy to get wrong. `moshpit_tlds .price_usd` sits on the ending's row but is the *child* price — what someone pays to mint `foo.bar`. Owning `.bar` means minting names under it for free; setting a price is how other people buy them. So $2 is the number that field carries, and the ending price is a separate thing. ENDING_PRICE_USD is defined and charged by nothing. `registerTld` inserts a row and claiming an ending is still free — the checkout that will read this needs terms and renewals first. It lives beside the child price anyway so the two are settled together, rather than being invented at the point someone builds that and reconciled afterwards. Still no enforcement on setTldPrice: a per-line `$5USD` is honoured. The ceiling is what the form defaults to and what the input hints at, not a rule the library imposes on an operator's own namespace. A test now fails on any price that is not whole dollars, so a regression to .99 cannot ship quietly. 263 across the pwa suite. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PRD 0005 §10.1 wrote these as $1.99 and $4.99. The extra cent buys nothing but a price tag shaped like a supermarket shelf, and every number here is one a person has to reason about — a default, a ceiling, a per-line override.
Which price is which
Worth stating, because it's easy to get backwards:
moshpit_tlds.price_usdsits on the ending's row but is the child price — what someone pays to mintfoo.bar.Owning
.barmeans minting names under it for free; setting a price is how other people buy them. So $2 is the number that field carries.$5 is defined and charged by nothing
registerTldinserts a row — claiming an ending is still free. The checkout that would readENDING_PRICE_USDneeds terms and renewals first (Phase 1 of the PRD rollout).It lives beside the child price anyway so the two are settled together, rather than being invented when someone builds that and reconciled afterwards. No UI claims endings cost money.
Still no enforcement
setTldPricedoesn't impose the ceiling — a per-line$5USDis honoured. The cap is what the form defaults to and what the input hints at, not a rule the library imposes on an operator's own namespace. (Enforcing it also breaks six existing sales tests that predate any cap.)Tests
A test now fails on any price that isn't whole dollars, so a regression to
.99can't ship quietly. 263/263 pwa suite.🤖 Generated with Claude Code