Skip to content

fix(skill): require a name flag value - #156

Merged
ralyodio merged 1 commit into
moshcoder:mainfrom
phucnguyen1707:fix/skill-name-value
Jul 31, 2026
Merged

fix(skill): require a name flag value#156
ralyodio merged 1 commit into
moshcoder:mainfrom
phucnguyen1707:fix/skill-name-value

Conversation

@phucnguyen1707

Copy link
Copy Markdown
Contributor

Summary

  • reject skill install ... --name when no value follows
  • reject another flag as the --name value
  • add CLI regression coverage

Testing

  • node --test test/skill-command.test.mjs test/mcp.test.mjs test/skills.test.mjs test/support-matrix.test.mjs

@ralyodio
ralyodio merged commit d659f1e into moshcoder:main Jul 31, 2026
3 checks passed
@ralyodio ralyodio mentioned this pull request Aug 1, 2026
ralyodio added a commit that referenced this pull request Aug 1, 2026
install.sh resolves releases/latest, so the sixteen commits merged since
v0.13.3 have been sitting on main unreachable — including a fix for a page
that locks browsers up.

The headline is the pit. /pit rendered every ending an account held and a form
per name under each, with no bound on either: at 50 endings x 100 names that
was 3.1 MiB of HTML and 36,082 DOM elements, and it managed to jam a browser
with no script on the page at all (#167). It now draws a window and says what
it is not drawing — 173 KiB, 1,926 elements — with a filter box over the top
that takes `eggs` as a substring and `def*` as a glob, debounced against the
API (#168).

The namespace also stopped being the one part of the product a script could
not touch: /api/moshpit/* now accepts the same API key /api/me and
/api/sessions already did (#169), and /pit/dns finally documents the
TronBrowser route for machines whose DNS is not theirs to change (#165).

  moshcode: foreign keys are enforced, and the licence package.json
  claims actually ships (#154)
  cli: help aliases exit 0 (#157), invalid integration commands fail (#160),
  `--` is honoured (#159), a BOM before a shebang no longer breaks (#158)
  skills: engines with no skills primitive are reported, not dropped (#166);
  `--name` requires a value (#156)
  mcp: an unsupported flag is rejected rather than registered as the server
  name (#164)
  pit: the namespace rules are vendored again with a drift test holding them
  to the published package (#161, #162, #163)

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants