feat(pit): give an ending its own page at /n/<ending> - #184
Merged
Conversation
`/n/torklink` and `/n/.torklink` both answered "not a Moshpit name". True of the string, useless about the registry: `.torklink` is one of 3707 endings somebody holds, with names under it. Landing on a dead end after typing a real thing is the worst answer the pit can give. An ending that is claimed now renders its own page — who holds it, the price of a name under it when one is set, everything living under it split by whether it points anywhere, and a box to pick a name. A leading dot is how people write endings, so `/n/.torklink` is accepted too. Not the name directory with a blank label: what a visitor can do here is different. There is no specific name to buy, so the offer is the ending's price and a box, and the listing is the whole ending rather than "what else lives near the name you asked for". An ending nobody holds still answers 400. Otherwise every typo under /n/ becomes an indexable page, and the pit already answers "claim it" for a whole name. Endings join the sitemap now that they resolve — the comment saying they could not be listed because they 400 was describing this bug. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This was referenced Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both of these answered "not a Moshpit name":
True of the string, useless about the registry —
.torklinkis one of 3707 endings somebody holds, with names under it. Landing on a dead end after typing a real thing is the worst answer the pit can give.Change
A claimed ending renders its own page: who holds it, the price of a name under it when one is set, everything living under it split by whether it points anywhere, and a box to pick a name.
/n/.torklinkworks too — a leading dot is how people write endings.Deliberately not the name directory with a blank label. What a visitor can do here is different: there's no specific name to buy, so the offer is the ending's price and a box, and the listing is the whole ending rather than "what else lives near the name you asked for".
An ending nobody holds still answers 400. Otherwise every typo under
/n/becomes an indexable page, and the pit already answers "claim it" for a whole name vialandingFor.Endings also join the sitemap now that they resolve — the comment I left there saying they couldn't be listed because they 400 was describing exactly this bug.
Verification
npm testinapps/pwa— 370 pass, 0 fail (9 new, route-level against a throwaway libSQL db):quoteNamewould refuse🤖 Generated with Claude Code