fix(pwa): compare against the moshpit-name that has the rule - #249
Merged
Conversation
apps/pwa's drift test has failed 3 subtests for a while, and the reason was never the vendored copy: `@moshcoder/moshpit-name` fixed the label rule — no dashes, because a dash is the cheapest way to mint a near-miss of an ending someone else holds — and never published it. npm served the old permitting regex, the test compared against that, and reported the fixed copy as the one out of step. Published now as 0.4.0. The specifier has to move with it: `^0.2.0` cannot resolve `0.4.0` on a 0.x range, so leaving it would go on comparing against the copy the release exists to replace. That caret is what hid this — the same trap that hid the DNS bridge divergence in #245. apps/pwa: 456 pass, 0 fail, 0 skipped. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the 3 long-standing failures in
apps/pwa/test/moshpit-name-drift.test.mjs.Why they were failing
Not the vendored copy.
@moshcoder/moshpit-namefixed the label rule — no dashes, because a dash is the cheapest way to mint a near-miss of an ending someone else holds (.cryptovs.cryp-to, in a namespace one level deep with no dispute process) — and never published it. npm went on serving the old permitting regex, the drift test compared against that, and reported the fixed copy as the one out of step.Published now as
0.4.0(moshcoder/moshpit-name#11).Why the specifier has to move too
^0.2.0cannot resolve0.4.0— a caret on a 0.x range is pinned to that minor. Leaving it would go on comparing against the exact copy the release exists to replace.That caret is what hid this, and it's the same trap that hid the DNS bridge divergence in #245: the drift test dutifully compared against a version that could never advance.
Result
apps/pwa: 456 pass, 0 fail, 0 skipped.No source change —
package.jsonand its lockfile only.🤖 Generated with Claude Code