Reject invalid moshscript characters - #5
Merged
ralyodio merged 1 commit intoJul 10, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a parser bug where invalid characters between otherwise valid moshscript tokens were silently skipped.
Example before this change:
say(@);compiled assay()instead of failing. That can make malformed scripts run with different behavior than the author wrote.This PR tracks tokenizer progress and throws when there is an unmatched gap or trailing invalid input. It also adds a small Node test suite covering the regression and one valid script path.
Validation:
npm testnode bin/moshcode.mjs run examples/alive.mosh --dry-run --max 1git diff --check