Fix: bid link relative /?bid (works on masked + direct parked domains) - #20
Merged
Conversation
PR #16 made the bid link https://<dn>/?bid=<dn> with target=_top. On a masked (Porkbun-forwarded) domain that breaks out to the branded domain, where the masked forward drops the ?bid query → you land back on the coming-soon page. Revert to a relative /?bid=<dn>. On a masked/iframed domain it navigates the frame to moshcoding.com/?bid=<dn> (same origin as the frame) and the ?bid CSP frame-ancestors rule (already in middleware) lets the bid page render in-frame, keeping the branded URL. On a direct domain it's a plain same-origin nav. Either way ?bid survives. Verified: tenant page emits href="/?bid=<dn>"; /?bid=<dn> renders BidPage; CSP on /?bid=<dn> includes the domain so it frames in-place. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
On a masked (Porkbun-forwarded) domain,
💰 Bid on this domaindid nothing useful — it sent you back to the coming-soon page. PR #16 had made ithttps://<dn>/?bid=<dn>+target=_top, which breaks out of the iframe to the branded domain, where the masked forward drops?bid.Fix
Relative
/?bid=<dn>:moshcoding.com/?bid=<dn>(same origin as the frame); the?bidframe-ancestorsrule (already in middleware) lets the bid page render in-frame, keeping the branded URL.Either way
?bidsurvives. No cookies involved, so no third-party-cookie issue.Verified (local)
<a class="t-bid" href="/?bid=moshcode.sh">/?bid=moshcode.sh→ BidPage/?bid=moshcode.sh→frame-ancestors 'self' … https://moshcode.sh …🤖 Generated with Claude Code