Skip to content

[DSD-9251]transfer dev to qa - #1390

Merged
abhishek8shankar merged 1 commit into
mosip:release-1.2.0.1from
bhumi46:patch-5
Nov 18, 2025
Merged

[DSD-9251]transfer dev to qa #1390
abhishek8shankar merged 1 commit into
mosip:release-1.2.0.1from
bhumi46:patch-5

Conversation

@bhumi46

@bhumi46 bhumi46 commented Nov 18, 2025

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated deployment images: removed legacy kernel service image and added new registration and packet service images for version 1.3.x.

Signed-off-by: bhumi46 <111699703+bhumi46@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Nov 18, 2025

Copy link
Copy Markdown

Walkthrough

The pull request modifies release/vidivi/images.txt to update Docker image references. It removes one kernel-syncdata-service image entry and adds two new service images (registration-client and commons-packet-service) both tagged with release-1.3.x.

Changes

Cohort / File(s) Summary
Release image configuration
release/vidivi/images.txt
Removed mosipdev/kernel-syncdata-service:MOSIP-43648-develop MOSIP-43648. Added mosipdev/registration-client:release-1.3.x 1.3.x and mosipdev/commons-packet-service:release-1.3.x 1.3.x

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • ckm007
  • dhanendra06

Poem

🐰 Images dance and shift away,
Old kernels fade, new services stay,
Registration clients now appear,
Packet services, release is here!
Hop hop, version-1.3.x cheer! 🎉

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding new image entries for registration-client and commons-packet-service.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d88b5b0 and a56dd09.

📒 Files selected for processing (1)
  • release/vidivi/images.txt (1 hunks)
🔇 Additional comments (2)
release/vidivi/images.txt (2)

1-2: Verify version alignment with target branch.

The added images are tagged with release-1.3.x and version 1.3.x, but the PR targets release-1.2.0.1. This version mismatch needs clarification—is this intentional or an error?

Additionally, the AI summary indicates that mosipdev/kernel-syncdata-service:MOSIP-43648-develop was removed, but no context is provided for why this service is no longer needed.


1-2: Format is consistent.

The added entries follow the established format (<repo>/<image>:<tag> <version>) and are consistent with the file's structure.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bhumi46 bhumi46 changed the title [DSD-9251]Added new image entries for registration and commons services [DSD-9251]transfer dev to qa Nov 18, 2025
@abhishek8shankar
abhishek8shankar merged commit eede7fc into mosip:release-1.2.0.1 Nov 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants