[DSD-9264] mosipdev to mosipqa - #1395
Conversation
Signed-off-by: Swapnil <swapnil.mohanty@technoforte.co.in>
WalkthroughThe change replaces a single release image reference (mosipdev/print:release-1.3.x) with three new development branch image entries (pmp-ui-v2, partner-management-service, and policy-management-service, all tagged to develop). Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| mosipdev/pmp-ui-v2:develop develop | ||
| mosipdev/partner-management-service:develop develop | ||
| mosipdev/policy-management-service:develop develop |
There was a problem hiding this comment.
🧩 Analysis chain
mosipdev instead of mosipqa.
The PR title states "[DSD-9264] mosipdev to mosipqa," but the three added entries all reference the mosipdev registry, not mosipqa:
mosipdev/pmp-ui-v2:developmosipdev/partner-management-service:developmosipdev/policy-management-service:develop
Additionally, adding development-tagged images (:develop) to a release branch file (release-1.2.0.1) should be verified to ensure this is intentional.
Please confirm:
- Should these entries reference
mosipqainstead ofmosipdev? - Are development branch images (
:developtags) appropriate for a release branch file? - Are these three services intentional replacements for the removed
mosipdev/print:release-1.3.ximage?
🏁 Script executed:
#!/bin/bash
# Search for mosipqa references in the entire repository
echo "=== Searching for mosipqa references ==="
rg -n "mosipqa" --type-list | head -5
rg -n "mosipqa" 2>/dev/null | head -20
echo -e "\n=== Full content of release/vidivi/images.txt ==="
cat release/vidivi/images.txt 2>/dev/null || echo "File not found"
echo -e "\n=== Check git status and recent changes ==="
git log --oneline -10 2>/dev/null || echo "Git not available"
git diff HEAD~1 HEAD -- release/vidivi/images.txt 2>/dev/null || echo "Cannot show diff"
echo -e "\n=== Search for DSD-9264 in commit messages ==="
git log --all --grep="DSD-9264" --oneline 2>/dev/null | head -5 || echo "Cannot search commits"
echo -e "\n=== Check for images.txt files across repo ==="
find . -name "images.txt" -type f 2>/dev/nullLength of output: 3631
🏁 Script executed:
#!/bin/bash
# Check the other images.txt file for context and pattern
echo "=== Content of release/checks/images.txt ==="
cat release/checks/images.txt 2>/dev/null || echo "File not found"
echo -e "\n=== Check if there are any mosipqa image entries in PR ==="
git diff HEAD~1 HEAD | grep -i "mosipqa" || echo "No mosipqa entries found in diff"
echo -e "\n=== Full git log for DSD-9264 commit ==="
git show ca9d86e --name-only 2>/dev/null || echo "Cannot show commit details"Length of output: 3118
mosipdev instead of mosipqa.
The PR title "[DSD-9264] mosipdev to mosipqa" explicitly states intent to migrate from mosipdev to mosipqa, but all three added entries still reference the mosipdev registry:
mosipdev/pmp-ui-v2:develop(should bemosipqa/pmp-ui-v2:...)mosipdev/partner-management-service:develop(should bemosipqa/partner-management-service:...)mosipdev/policy-management-service:develop(should bemosipqa/policy-management-service:...)
Additionally, the entries use development-tagged images (:develop) instead of release tags, which may be incorrect for a release branch file.
Verify:
- Should these entries use
mosipqaregistry instead ofmosipdev? - Are
:developtags appropriate, or should they use release versions (e.g.,1.3.x)?
🤖 Prompt for AI Agents
In release/vidivi/images.txt around lines 1 to 3, the three image entries
incorrectly reference the mosipdev registry and use :develop tags; update each
image name to the mosipqa registry (e.g., mosipqa/pmp-ui-v2,
mosipqa/partner-management-service, mosipqa/policy-management-service) and
replace the :develop tags with the correct release tags (use the intended
release version like :1.3.x or the exact release tag used by this branch); if
you’re unsure of the exact version, query the release manifest or CI/CD pipeline
to obtain the canonical release tag before committing the change and ensure all
entries match that release tag.
2 participants
Summary by CodeRabbit