Skip to content

[DSD-9503] mosipdev2 to mosipqa - #1485

Merged
Prafulrakhade merged 1 commit into
mosip:release-1.2.0.1from
gaganamadival:release-1.2.0.1
Dec 16, 2025
Merged

[DSD-9503] mosipdev2 to mosipqa#1485
Prafulrakhade merged 1 commit into
mosip:release-1.2.0.1from
gaganamadival:release-1.2.0.1

Conversation

@gaganamadival

@gaganamadival gaganamadival commented Dec 16, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated development infrastructure configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: gaganamadival <94885434+gaganamadival@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Dec 16, 2025

Copy link
Copy Markdown

Walkthrough

Updates container image references in the release configuration by replacing a single eSignet signup image with two development images: inji-web and mimoto, both using the develop tag.

Changes

Cohort / File(s) Summary
Release image configuration
release/vidivi/images.txt
Replaces mosipdev2/apitest-esignet-signup:release-1.3.x with two new development images: mosipdev2/inji-web:develop and mosipdev2/mimoto:develop

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • ckm007

Poem

🐰 A developer's hop, images take flight,
Old eSignet fades into the night,
Inji and Mimoto dance in develop's glow,
The release-vidivi pipeline's off we go!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title indicates changing 'mosipdev2' to 'mosipqa', but the actual changes show replacement of a mosipdev2 image with two different mosipdev2 images for development purposes, not a migration to mosipqa. Update the title to accurately reflect the actual changes, such as 'DSD-9503 Replace apitest-esignet-signup image with inji-web and mimoto development images' or clarify the mosipqa migration intent.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Prafulrakhade
Prafulrakhade merged commit 9673e74 into mosip:release-1.2.0.1 Dec 16, 2025
1 of 2 checks passed

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c36fa6e and d79fef6.

📒 Files selected for processing (1)
  • release/vidivi/images.txt (1 hunks)

Comment thread release/vidivi/images.txt
Comment on lines +1 to +2
mosipdev2/inji-web:develop develop
mosipdev2/mimoto:develop develop

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Search for PR references, registry configuration, and recent changes

# First, check git log for DSD-9503 commits
echo "=== Git history for DSD-9503 or related commits ==="
git log --all --oneline --grep="DSD-9503\|mosipqa\|mosipdev2" -20 2>/dev/null || echo "No matching commits found"

echo -e "\n=== Current content of the file ==="
cat -n release/vidivi/images.txt 2>/dev/null || echo "File not found"

echo -e "\n=== Check git diff history for this file ==="
git log --oneline release/vidivi/images.txt 2>/dev/null | head -10 || echo "File not in git history"

echo -e "\n=== Recent changes to the file ==="
git log -p --follow release/vidivi/images.txt 2>/dev/null | head -50 || echo "No history available"

Repository: mosip/release-script

Length of output: 1454


🏁 Script executed:

#!/bin/bash
# Get the actual diff of the most recent commit
echo "=== Commit d79fef6 diff ==="
git show d79fef6 --stat

echo -e "\n=== Full diff of release/vidivi/images.txt in that commit ==="
git show d79fef6 -- release/vidivi/images.txt 2>/dev/null || echo "File not in that commit"

echo -e "\n=== Check what the old content was (before the commit) ==="
git show d79fef6^:release/vidivi/images.txt 2>/dev/null || echo "Previous version not available"

Repository: mosip/release-script

Length of output: 3372


🏁 Script executed:

#!/bin/bash
# Examine related files in vidivi directory for context
echo "=== vidivi/README.md excerpt ==="
head -100 release/vidivi/README.md 2>/dev/null || echo "README not found"

echo -e "\n=== vidivi/config.yml ==="
cat release/vidivi/config.yml 2>/dev/null || echo "Config not found"

echo -e "\n=== Similar PR DSD-9452 (mosipdev2 to mosipqa) ==="
git show d226c6e -- release/vidivi/images.txt 2>/dev/null | head -30 || echo "Not available"

echo -e "\n=== List all files in release/vidivi directory ==="
ls -la release/vidivi/ 2>/dev/null || echo "Directory not found"

Repository: mosip/release-script

Length of output: 7145


Registry mismatch: PR title indicates mosipqa but images reference mosipdev2.

The commit message "[DSD-9503] mosipdev2 to mosipqa" contradicts the file content. According to the documented lifecycle (mosipdev → mosipdev2 → mosipqa → mosipid), images should reference mosipqa, not mosipdev2. Additionally, using develop tags on a release configuration is inconsistent with the release-versioning pattern shown in related PRs.

🤖 Prompt for AI Agents
In release/vidivi/images.txt lines 1-2, the image registry and tags are
incorrect: they reference mosipdev2 and use the develop tag while the PR title
and lifecycle require mosipqa and a release-style tag. Update both lines to
point to the mosipqa registry (e.g., mosipqa/inji-web and mosipqa/mimoto) and
replace the "develop" tag with the correct release tag used by related PRs
(e.g., the specific release version or semantic tag), and verify the final
values match the documented lifecycle and the PR title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants