Skip to content

[DSD-9516] mosipdev to mosipqa - #1501

Merged
abhishek8shankar merged 1 commit into
mosip:release-1.2.0.1from
SwapnilWorks-Devops:release-1.2.0.1
Dec 22, 2025
Merged

[DSD-9516] mosipdev to mosipqa#1501
abhishek8shankar merged 1 commit into
mosip:release-1.2.0.1from
SwapnilWorks-Devops:release-1.2.0.1

Conversation

@SwapnilWorks-Devops

@SwapnilWorks-Devops SwapnilWorks-Devops commented Dec 22, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated image references in deployment configuration to track the latest development builds instead of previous release versions.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Swapnil <swapnil.mohanty@technoforte.co.in>
@coderabbitai

coderabbitai Bot commented Dec 22, 2025

Copy link
Copy Markdown

Walkthrough

This pull request updates the image registry in release/vidivi/images.txt by removing two release-1.3.x image entries for dsl-orchestrator and dsl-packetcreator components, and adding a single develop-tagged pmp-ui-v2 image entry.

Changes

Cohort / File(s) Summary
Image Registry Update
release/vidivi/images.txt
Removed two 1.3.x image entries (mosipdev2/dsl-orchestrator:release-1.3.x, mosipdev2/dsl-packetcreator:release-1.3.x) and added one develop-tagged image (mosipdev/pmp-ui-v2:develop)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

This is a straightforward manifest update affecting a single file with three lines changed (two removed, one added). No logic, no structural changes, purely configuration-level edits.

Possibly related PRs

Suggested reviewers

  • ckm007

Poem

🐰 A rabbit hops through images bright,
Two old versions fade from sight,
A shiny new dev tag takes their place,
In the registry, a swifter pace! 🚀

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title states 'mosipdev to mosipqa' but the changes show replacing 'mosipdev2' images with 'mosipdev' (not 'mosipqa'), and updating component versions/tags, not switching to qa environment. Revise the title to accurately reflect the actual changes, such as 'DSD-9516 Update image references from 1.3.x releases to pmp-ui-v2 develop' or clarify the intended scope if qa migration is planned.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 34951f9 and 4fa8e6d.

📒 Files selected for processing (1)
  • release/vidivi/images.txt
🔇 Additional comments (1)
release/vidivi/images.txt (1)

1-1: Using develop tag in a release branch is atypical and may be risky.

The added line uses the develop tag for pmp-ui-v2 on the release-1.2.0.1 branch, which typically expects stable, versioned image tags rather than development builds. Confirm that this is intentional and aligns with the release strategy.

Comment thread release/vidivi/images.txt
@@ -1,2 +1 @@
mosipdev2/dsl-orchestrator:release-1.3.x 1.3.x
mosipdev2/dsl-packetcreator:release-1.3.x 1.3.x
mosipdev/pmp-ui-v2:develop develop

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verification of release/vidivi/images.txt changes

# Check if file exists
if [ ! -f release/vidivi/images.txt ]; then
  echo "File does not exist: release/vidivi/images.txt"
  exit 1
fi

echo "=== Complete file content ==="
cat release/vidivi/images.txt

echo ""
echo "=== Git diff for the file ==="
git diff HEAD release/vidivi/images.txt || echo "No git diff available"

echo ""
echo "=== File line count ==="
wc -l release/vidivi/images.txt

echo ""
echo "=== Registry usage count ==="
echo "mosipdev occurrences: $(grep -c 'mosipdev' release/vidivi/images.txt || echo 0)"
echo "mosipqa occurrences: $(grep -c 'mosipqa' release/vidivi/images.txt || echo 0)"

Repository: mosip/release-script

Length of output: 291


Update registry from mosipdev to mosipqa to align with PR intent.

The PR title "[DSD-9516] mosipdev to mosipqa" indicates a migration to the mosipqa registry, but the code still references mosipdev/pmp-ui-v2:develop. Change mosipdev/pmp-ui-v2:develop to mosipqa/pmp-ui-v2:develop to match the stated objective. Additionally, using the develop tag on a release branch is non-standard; consider using a stable version tag instead.

🤖 Prompt for AI Agents
In release/vidivi/images.txt around lines 1 to 1, update the image reference
from "mosipdev/pmp-ui-v2:develop" to "mosipqa/pmp-ui-v2:develop" to match the PR
intent; additionally replace the non-standard "develop" tag with an appropriate
stable version tag (e.g., a release semver or commit SHA) before committing so
the release branch references a fixed, reproducible image.

@abhishek8shankar
abhishek8shankar merged commit ee3549a into mosip:release-1.2.0.1 Dec 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants