[DSD-9585] mosipdev2 to mosipqa - #1511
Conversation
Signed-off-by: gaganamadival <94885434+gaganamadival@users.noreply.github.com>
WalkthroughThe pull request updates image references in the release configuration by removing a single inji-usecase service image and replacing it with two new inji verification service images, migrating from mosipdev to mosipdev2 registry. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @release/vidivi/images.txt:
- Around line 1-2: The two image entries in release/vidivi/images.txt
(mosipdev2/inji-verify-service:develop and mosipdev2/inji-verify-ui:develop) use
the mutable develop tag; replace each with an immutable reference (a fixed
semantic version tag or image digest, e.g. mosipdev2/inji-verify-service:v1.2.3
or mosipdev2/inji-verify-service@sha256:<digest>) to ensure deterministic
deployments, or if develop is intentional for a non-prod environment, add a
clear comment in the file noting this is a mutable development tag and not for
production.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
release/vidivi/images.txt
🔇 Additional comments (2)
release/vidivi/images.txt (2)
1-2: No evidence ofinji-usecasein the codebase.A comprehensive search found zero references to
inji-usecaseanywhere in the repository. The change shown addsinji-verify-serviceandinji-verify-uitorelease/vidivi/images.txt, but there is no existinginji-usecaseservice being replaced. This is not a breaking change within this codebase, and no downstream impact assessment is needed unless this change affects external systems outside this repository.Likely an incorrect or invalid review comment.
1-2: Clarify PR intent: Registry transfer direction and image tag stability.The file correctly shows
mosipdev2as the source registry (consistent with transferring FROM mosipdev2 TO mosipqa), but the PR title should explicitly clarify that this is a source image list for the transfer workflow. Additionally, using thedeveloptag creates non-deterministic deployments; consider pinning to specific release versions if these images should be stable QA candidates.
| mosipdev2/inji-verify-service:develop develop | ||
| mosipdev2/inji-verify-ui:develop develop |
There was a problem hiding this comment.
Avoid using mutable develop tag for production deployments.
Both images use the develop tag, which is mutable and can change without notice, leading to non-deterministic deployments. For production or stable environments, pin to specific image digests or immutable version tags. If this is intended for a development environment, document this decision clearly.
🤖 Prompt for AI Agents
In @release/vidivi/images.txt around lines 1 - 2, The two image entries in
release/vidivi/images.txt (mosipdev2/inji-verify-service:develop and
mosipdev2/inji-verify-ui:develop) use the mutable develop tag; replace each with
an immutable reference (a fixed semantic version tag or image digest, e.g.
mosipdev2/inji-verify-service:v1.2.3 or
mosipdev2/inji-verify-service@sha256:<digest>) to ensure deterministic
deployments, or if develop is intentional for a non-prod environment, add a
clear comment in the file noting this is a mutable development tag and not for
production.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.