[DSD-9605] mosipdev to mosipdev2 - #1512
Conversation
Signed-off-by: Swapnil <swapnil.mohanty@technoforte.co.in>
WalkthroughThis change updates the vidivi release image manifest by replacing two separate verify service and UI image entries with a single consolidated inji-certify-with-plugins image entry, simplifying the image configuration. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @release/vidivi/images.txt:
- Line 1: The PR title is backwards and the release entries are unsafe: change
the PR title from "[DSD-9605] mosipdev to mosipdev2" to reflect that mosipdev2
images (inji-verify-service and inji-verify-ui) are being replaced by
mosipdev/inji-certify-with-plugins, update release/vidivi/images.txt to use a
stable release tag instead of "develop" for
mosipdev/inji-certify-with-plugins:develop and clarify the consolidation by
either listing the removed images (inji-verify-service, inji-verify-ui)
alongside the new image or adding a comment that inji-certify-with-plugins
contains both services, and include verification steps (tests or manifest check)
proving inji-certify-with-plugins includes the functionality of both removed
services before merging.
| @@ -1,2 +1 @@ | |||
| mosipdev2/inji-verify-service:develop develop | |||
| mosipdev2/inji-verify-ui:develop develop | |||
| mosipdev/inji-certify-with-plugins:develop develop | |||
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
git diff HEAD~1 HEAD -- release/vidivi/images.txtRepository: mosip/release-script
Length of output: 94
🏁 Script executed:
git log --oneline -10 --allRepository: mosip/release-script
Length of output: 614
🏁 Script executed:
git show HEAD:release/vidivi/images.txtRepository: mosip/release-script
Length of output: 114
🏁 Script executed:
cat -n release/vidivi/images.txtRepository: mosip/release-script
Length of output: 121
🏁 Script executed:
git show 6e75ecc:release/vidivi/images.txtRepository: mosip/release-script
Length of output: 150
PR title is backwards — change goes from mosipdev2 to mosipdev, not the reverse. Additionally, consolidating two services with a develop tag in a release branch needs clarification.
The PR title "[DSD-9605] mosipdev to mosipdev2" is incorrect. The actual change replaces two mosipdev2/ images (inji-verify-service and inji-verify-ui) with a single mosipdev/ image (inji-certify-with-plugins), which is the opposite direction stated in the title.
Additionally:
- Using the
developtag in a release branch context is concerning, as it typically points to unstable versions rather than stable release versions. - The consolidation of two separate services into a single image (
inji-certify-with-plugins) requires confirmation that the new image contains all functionality from both removed services.
🤖 Prompt for AI Agents
In @release/vidivi/images.txt at line 1, The PR title is backwards and the
release entries are unsafe: change the PR title from "[DSD-9605] mosipdev to
mosipdev2" to reflect that mosipdev2 images (inji-verify-service and
inji-verify-ui) are being replaced by mosipdev/inji-certify-with-plugins, update
release/vidivi/images.txt to use a stable release tag instead of "develop" for
mosipdev/inji-certify-with-plugins:develop and clarify the consolidation by
either listing the removed images (inji-verify-service, inji-verify-ui)
alongside the new image or adding a comment that inji-certify-with-plugins
contains both services, and include verification steps (tests or manifest check)
proving inji-certify-with-plugins includes the functionality of both removed
services before merging.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.