Skip to content

[DSD-9605] mosipdev to mosipdev2 - #1512

Merged
abhishek8shankar merged 1 commit into
mosip:release-1.2.0.1from
SwapnilWorks-Devops:release-1.2.0.1
Jan 12, 2026
Merged

[DSD-9605] mosipdev to mosipdev2#1512
abhishek8shankar merged 1 commit into
mosip:release-1.2.0.1from
SwapnilWorks-Devops:release-1.2.0.1

Conversation

@SwapnilWorks-Devops

@SwapnilWorks-Devops SwapnilWorks-Devops commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Consolidated container image references in the release configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Swapnil <swapnil.mohanty@technoforte.co.in>
@coderabbitai

coderabbitai Bot commented Jan 12, 2026

Copy link
Copy Markdown

Walkthrough

This change updates the vidivi release image manifest by replacing two separate verify service and UI image entries with a single consolidated inji-certify-with-plugins image entry, simplifying the image configuration.

Changes

Cohort / File(s) Summary
Release Image Manifest
release/vidivi/images.txt
Removed mosipdev2/inji-verify-service and mosipdev2/inji-verify-ui entries; added mosipdev/inji-certify-with-plugins:develop. Net: 2 lines removed, 1 line added.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • ckm007

Poem

🐰 The manifest hops with simplicity new,
Two verify images merge into one view,
Certify-with-plugins takes center stage,
Release config dances across the page! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title states 'mosipdev to mosipdev2', but the actual change is replacing 'mosipdev2' entries with a new 'mosipdev' entry, which is the opposite direction. Correct the title to accurately reflect the change, such as 'DSD-9605 Replace verify service/ui images with inji-certify-with-plugins' or 'DSD-9605 mosipdev2 to mosipdev'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@abhishek8shankar
abhishek8shankar merged commit e8f0ed4 into mosip:release-1.2.0.1 Jan 12, 2026
1 of 2 checks passed

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @release/vidivi/images.txt:
- Line 1: The PR title is backwards and the release entries are unsafe: change
the PR title from "[DSD-9605] mosipdev to mosipdev2" to reflect that mosipdev2
images (inji-verify-service and inji-verify-ui) are being replaced by
mosipdev/inji-certify-with-plugins, update release/vidivi/images.txt to use a
stable release tag instead of "develop" for
mosipdev/inji-certify-with-plugins:develop and clarify the consolidation by
either listing the removed images (inji-verify-service, inji-verify-ui)
alongside the new image or adding a comment that inji-certify-with-plugins
contains both services, and include verification steps (tests or manifest check)
proving inji-certify-with-plugins includes the functionality of both removed
services before merging.
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6e75ecc and f52aa58.

📒 Files selected for processing (1)
  • release/vidivi/images.txt

Comment thread release/vidivi/images.txt
@@ -1,2 +1 @@
mosipdev2/inji-verify-service:develop develop
mosipdev2/inji-verify-ui:develop develop
mosipdev/inji-certify-with-plugins:develop develop

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

git diff HEAD~1 HEAD -- release/vidivi/images.txt

Repository: mosip/release-script

Length of output: 94


🏁 Script executed:

git log --oneline -10 --all

Repository: mosip/release-script

Length of output: 614


🏁 Script executed:

git show HEAD:release/vidivi/images.txt

Repository: mosip/release-script

Length of output: 114


🏁 Script executed:

cat -n release/vidivi/images.txt

Repository: mosip/release-script

Length of output: 121


🏁 Script executed:

git show 6e75ecc:release/vidivi/images.txt

Repository: mosip/release-script

Length of output: 150


PR title is backwards — change goes from mosipdev2 to mosipdev, not the reverse. Additionally, consolidating two services with a develop tag in a release branch needs clarification.

The PR title "[DSD-9605] mosipdev to mosipdev2" is incorrect. The actual change replaces two mosipdev2/ images (inji-verify-service and inji-verify-ui) with a single mosipdev/ image (inji-certify-with-plugins), which is the opposite direction stated in the title.

Additionally:

  • Using the develop tag in a release branch context is concerning, as it typically points to unstable versions rather than stable release versions.
  • The consolidation of two separate services into a single image (inji-certify-with-plugins) requires confirmation that the new image contains all functionality from both removed services.
🤖 Prompt for AI Agents
In @release/vidivi/images.txt at line 1, The PR title is backwards and the
release entries are unsafe: change the PR title from "[DSD-9605] mosipdev to
mosipdev2" to reflect that mosipdev2 images (inji-verify-service and
inji-verify-ui) are being replaced by mosipdev/inji-certify-with-plugins, update
release/vidivi/images.txt to use a stable release tag instead of "develop" for
mosipdev/inji-certify-with-plugins:develop and clarify the consolidation by
either listing the removed images (inji-verify-service, inji-verify-ui)
alongside the new image or adding a comment that inji-certify-with-plugins
contains both services, and include verification steps (tests or manifest check)
proving inji-certify-with-plugins includes the functionality of both removed
services before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants