[DSD-9680] injistack to injistackdev2 - #1535
Conversation
Added new image entries for injistackdev services. Signed-off-by: gaganamadival <94885434+gaganamadival@users.noreply.github.com>
WalkthroughThis change updates a release image manifest, replacing multiple Changes
Sequence Diagram(s)(omitted — changes are a data-only manifest update without multi-component control-flow) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@release/vidivi/images.txt`:
- Around line 1-2: The release branch contains mutable tags in
release/vidivi/images.txt (lines with "injistackdev/inji-web:develop develop"
and "injistackdev/mimoto:develop develop"); replace the source image tags with
immutable tags or digests (e.g., pin to a specific semantic-version tag or
sha256 digest) so the mirrored images are reproducible, or if mirroring the live
develop tag is intentional, add a short comment in images.txt documenting that
behavior and the rationale for accepting mutable tags in this release workflow.
| injistackdev/inji-web:develop develop | ||
| injistackdev/mimoto:develop develop |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, let's confirm the file exists and check its current content
cat -n release/vidivi/images.txt 2>&1 || echo "File not found at that location"Repository: mosip/release-script
Length of output: 151
🏁 Script executed:
# Search for all images.txt files in the repo
fd -t f "images.txt"Repository: mosip/release-script
Length of output: 115
🏁 Script executed:
# Check git history for this file if it exists
git log --oneline --follow release/vidivi/images.txt 2>&1 | head -20Repository: mosip/release-script
Length of output: 109
🏁 Script executed:
# Search for references to mosipdev and injistackdev in the codebase
echo "=== Searching for mosipdev references ==="
rg -i "mosipdev" -A 2 -B 2 2>&1 | head -50
echo -e "\n=== Searching for injistackdev references ==="
rg -i "injistackdev" -A 2 -B 2 2>&1 | head -50Repository: mosip/release-script
Length of output: 5170
🏁 Script executed:
# Check if this is actually in a release branch by examining branch-related files
git branch -a 2>&1 | grep -i release | head -10Repository: mosip/release-script
Length of output: 162
🏁 Script executed:
# Look at the directory structure to understand the project better
ls -la release/ 2>&1 || echo "No release directory found"Repository: mosip/release-script
Length of output: 641
🏁 Script executed:
# Check git diff/show for the specific file to see what changed
git show bbba4a7 -- release/vidivi/images.txt 2>&1 || echo "Commit did not modify this file"Repository: mosip/release-script
Length of output: 663
🏁 Script executed:
# Check the full git log for this specific file
git log -p release/vidivi/images.txt 2>&1 | head -100Repository: mosip/release-script
Length of output: 46
🏁 Script executed:
# Check the other images.txt file to understand format better
echo "=== Content of release/checks/images.txt ==="
cat -n release/checks/images.txt 2>&1 || echo "File not found"Repository: mosip/release-script
Length of output: 3210
🏁 Script executed:
# Search for how images.txt files are used in the codebase
echo "=== Searching for references to images.txt ==="
rg "images\.txt" -B 2 -A 2 2>&1 | head -80Repository: mosip/release-script
Length of output: 1647
🏁 Script executed:
# Check if develop tags are actually used elsewhere in release scripts
echo "=== Searching for :develop tag usage ==="
rg ":develop" -A 2 -B 2 2>&1 | head -80Repository: mosip/release-script
Length of output: 230
🏁 Script executed:
# Look at the vidivi.py script to understand what this file does
head -100 release/vidivi/vidivi.py 2>&1 | cat -nRepository: mosip/release-script
Length of output: 3257
🏁 Script executed:
# Search for how destination tags are used in the vidivi script
grep -n "destination" release/vidivi/vidivi.py | head -20Repository: mosip/release-script
Length of output: 1663
🏁 Script executed:
# Look for any comments or documentation about tag handling
grep -n "tag" release/vidivi/README.md | head -30Repository: mosip/release-script
Length of output: 1085
Using mutable develop tags in a release branch may affect reproducibility.
This file was newly added (not replacing existing entries). The format is correct: source-image:source-tag destination-tag. However, using the mutable develop tag for images in a release branch (release-1.2.0.1) could be problematic:
- The
developtag can change at any time in the source registry, making image transfers non-deterministic - This breaks the reproducibility expectation for release artifacts
- Future transfers may pull different image content than originally intended
Recommendation: Use immutable tags or digest hashes for release branches. If develop mirroring is intentional for this workflow, clarify the use case and consider documenting why mutable tags are acceptable in this context.
🤖 Prompt for AI Agents
In `@release/vidivi/images.txt` around lines 1 - 2, The release branch contains
mutable tags in release/vidivi/images.txt (lines with
"injistackdev/inji-web:develop develop" and "injistackdev/mimoto:develop
develop"); replace the source image tags with immutable tags or digests (e.g.,
pin to a specific semantic-version tag or sha256 digest) so the mirrored images
are reproducible, or if mirroring the live develop tag is intentional, add a
short comment in images.txt documenting that behavior and the rationale for
accepting mutable tags in this release workflow.
Signed-off-by: gaganamadival <94885434+gaganamadival@users.noreply.github.com>
2 participants
Added new image entries for injistackdev services.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.