[DSD-9834] injistackdev to injistackdev2 - #1595
Conversation
Signed-off-by: gaganamadival <94885434+gaganamadival@users.noreply.github.com>
WalkthroughUpdated the Vidivi release image manifest by replacing three mosipdev entries (pmp-ui-v2, partner-management-service, policy-management-service) with two injistackdev entries (inji-web, mimoto). Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@release/vidivi/images.txt`:
- Around line 1-2: The two image entries "injistackdev/inji-web:develop develop"
and "injistackdev/mimoto:develop develop" use the registry name injistackdev but
the PR title indicates the registry should be injistackdev2; update those image
references to use injistackdev2 (i.e., change the prefix injistackdev to
injistackdev2 for the "inji-web" and "mimoto" entries) so the registry names
match the intended target.
| injistackdev/inji-web:develop develop | ||
| injistackdev/mimoto:develop develop |
There was a problem hiding this comment.
Registry name mismatch with PR title — verify injistackdev vs injistackdev2.
The PR title states "injistackdev to injistackdev2", implying the intended registry is injistackdev2, but both added entries use injistackdev. If the goal was to point to injistackdev2, these lines are incorrect.
🔧 Proposed fix if `injistackdev2` was the intended registry
-injistackdev/inji-web:develop develop
-injistackdev/mimoto:develop develop
+injistackdev2/inji-web:develop develop
+injistackdev2/mimoto:develop develop📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| injistackdev/inji-web:develop develop | |
| injistackdev/mimoto:develop develop | |
| injistackdev2/inji-web:develop develop | |
| injistackdev2/mimoto:develop develop |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@release/vidivi/images.txt` around lines 1 - 2, The two image entries
"injistackdev/inji-web:develop develop" and "injistackdev/mimoto:develop
develop" use the registry name injistackdev but the PR title indicates the
registry should be injistackdev2; update those image references to use
injistackdev2 (i.e., change the prefix injistackdev to injistackdev2 for the
"inji-web" and "mimoto" entries) so the registry names match the intended
target.
Summary by CodeRabbit