[DSD-10275] mosipdev to mosipqa - #1691
Conversation
Signed-off-by: Swapnil <swapnil.mohanty@technoforte.co.in>
WalkthroughThe pull request updates ChangesRelease Image Tag Updates
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@release/vidivi/images.txt`:
- Around line 1-8: The file still lists mosipdev/* images but the PR intends
mosipqa; update the namespace and tags accordingly: replace
mosipdev/credential-service, mosipdev/credential-request-generator,
mosipdev/id-repository-identity-service, mosipdev/id-repository-vid-service, and
mosipdev/id-repository-salt-generator to mosipqa/* and use release-1.2.3.x
(since 1.2.4.x is unavailable in mosipqa), and change
mosipdev/authentication-service, mosipdev/authentication-internal-service, and
mosipdev/authentication-otp-service to mosipqa/* with release-1.2.1.x (instead
of 1.2.2.x); alternatively, if the intent was to keep mosipdev images, correct
the PR title from "mosipdev to mosipqa" to reflect no namespace change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0b2410b0-a5cb-4b60-abc2-a739db34fd25
📒 Files selected for processing (1)
release/vidivi/images.txt
| mosipdev/credential-service:release-1.2.4.x 1.2.4.x | ||
| mosipdev/credential-request-generator:release-1.2.4.x 1.2.4.x | ||
| mosipdev/id-repository-identity-service:release-1.2.4.x 1.2.4.x | ||
| mosipdev/id-repository-vid-service:release-1.2.4.x 1.2.4.x | ||
| mosipdev/id-repository-salt-generator:release-1.2.4.x 1.2.4.x | ||
| mosipdev/authentication-service:release-1.2.2.x 1.2.2.x | ||
| mosipdev/authentication-internal-service:release-1.2.2.x 1.2.2.x | ||
| mosipdev/authentication-otp-service:release-1.2.2.x 1.2.2.x |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Check if mosipqa versions of these images exist in Docker Hub
echo "Checking for mosipqa image variants..."
for service in credential-service credential-request-generator id-repository-identity-service id-repository-vid-service id-repository-salt-generator authentication-service authentication-internal-service authentication-otp-service; do
echo "Checking mosipqa/${service}..."
curl -s "https://hub.docker.com/v2/repositories/mosipqa/${service}/tags" | jq -r '.results[].name' | head -5 || echo " Failed to fetch or image not found"
doneRepository: mosip/release-script
Length of output: 835
Critical: PR title contradicts file content AND incompatible version tags.
The PR title "[DSD-10275] mosipdev to mosipqa" implies images should be FROM mosipdev TO mosipqa, but the file still contains mosipdev/* images. Additionally, if the intent is to convert to mosipqa, the version tags used are incompatible:
- Lines 1-5:
release-1.2.4.xdoes not exist in mosipqa (max available:1.2.3.x) - Lines 6-8:
release-1.2.2.xdoes not exist in mosipqa for authentication services (only1.2.1.xavailable)
This creates three actionable problems:
- Namespace mismatch: File uses
mosipdev/*but PR title indicatesmosipqa/* - Version tag mismatch:
1.2.4.xunavailable in mosipqa - Authentication version mismatch:
1.2.2.xshould be1.2.1.xfor mosipqa
Clarify whether the PR title should be corrected or the file content should be updated to use the correct mosipqa namespace and available version tags.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@release/vidivi/images.txt` around lines 1 - 8, The file still lists
mosipdev/* images but the PR intends mosipqa; update the namespace and tags
accordingly: replace mosipdev/credential-service,
mosipdev/credential-request-generator, mosipdev/id-repository-identity-service,
mosipdev/id-repository-vid-service, and mosipdev/id-repository-salt-generator to
mosipqa/* and use release-1.2.3.x (since 1.2.4.x is unavailable in mosipqa), and
change mosipdev/authentication-service,
mosipdev/authentication-internal-service, and
mosipdev/authentication-otp-service to mosipqa/* with release-1.2.1.x (instead
of 1.2.2.x); alternatively, if the intent was to keep mosipdev images, correct
the PR title from "mosipdev to mosipqa" to reflect no namespace change.
2 participants
Summary by CodeRabbit