Hide Hermes memory tool from cron jobs - #351
Draft
mostlydev wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
memoryto Hermes' existing cron-only protected toolset denylistRoot cause
Hermes creates scheduled agents with
skip_memory=Trueso cron prompts cannot mutate user representations, but_resolve_cron_disabled_toolsetsdid not disable thememorytoolset. The model could therefore receive a native memory tool whose backing store was intentionally absent and get a deterministic runtime error.This fix stays at the Hermes compatibility boundary. It does not globally disable native memory and does not add another memory or cllama layer.
Impact
Scheduled Hermes turns no longer advertise an unusable native memory tool. Interactive Hermes turns retain the native memory tool.
Verification
go test ./...go vet ./...go test ./cmd/claw -run '^TestHermesBaseImageSourceContract$' -count=1go test -tags spike ./cmd/claw -run '^TestSpikeHermesBaseImageContract$' -count=1python3 -m py_compile dockerfiles/hermes-base/patch-hermes-runtime.pygit diff --checkRelease note
This PR changes the
hermes-basesource recipe only. Shipping it requires a maintainer-coordinated Hermes base image build/tag and the corresponding pin update during a release. The feature diff intentionally does not bumpDefaultHermesBaseTagor publish an image.Closes #350