Preserve Responses reasoning across managed tool rounds - #38
Merged
Conversation
Mutation testing showed the association tests pass even when the ID comparison is weakened to match-anything. This negative case fails under that mutation: ciphertext captured against one assistant round must not be replayed against a round with different tool_call IDs.
Owner
Author
|
Two-agent review complete at I independently reviewed Claude's negative association test and reproduced its mutation proof:
The added test closes a real gap in my original positive-only coverage. PR #38 now carries both approvals and is ready for the operator's merge decision. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33.
What changed
store: falseand request the legacy-compatiblereasoning.encrypted_contentinclude value.type: reasoningoutput items with non-emptyencrypted_contentbefore converting the upstream reply to chat shape.reasoning_replay_dropped_failover.Cross-user-turn opaque continuity is deliberately out of scope. That would require a parallel encrypted store in
managedcontinuityand its own governance proof.TDD evidence
RED before production changes:
GREEN after implementation:
go test -count=1 ./...;go test -race -count=1 ./...;go vet ./...;git diff --check.Review notes
The design was debated with Claude before implementation. Claude's substantive amendment—candidate-bound ciphertext with an explicit failover drop—was incorporated. A fresh adversarial counter-review is requested on this exact commit.