Fix a mistake in /docs/functions/sys.html: y/Y - #831
Open
xiaobsh wants to merge 1 commit into
Open
Conversation
TCNOco
added a commit
to TCNOco/Shell
that referenced
this pull request
Aug 16, 2026
moudey#834 (MissinLinkk05551) - menu and tooltip positioning on monitors with negative virtual-screen coordinates. _rcMonitor holds true virtual-screen coordinates, but the tooltip clamped its left and top against literal 0 while the right edge, two lines below, already clamped against _rcMonitor.right; and the scrolling-popup path assigned Rect::height() - a size - straight into WINDOWPOS::y, an absolute coordinate. A display stacked above the primary has a negative top, which is what put menus on the wrong monitor. Both are no-ops when the monitor's origin is (0,0), so single-monitor setups are unaffected. The PR's third hunk is not taken. It rewrites the condition of an else-if whose body is entirely commented out, so it changes nothing, and it would leave the adjacent inert branch using height() where this one uses bottom - which reads like a surviving bug. Both are commented where they are, with a note that they are inert. moudey#831 (xiaobsh) - docs had sys.datetime's y and Y swapped. Confirmed against string::TimeFormat: 'Y' is wYear % 100 and 'y' is %04u, so the page had them backwards. While there, the same block gave the time separator as '.' for sys.datetime, sys.datetime.short and sys.datetime.time, where the format strings use ':'. moudey#811 (ironsand) - the uninstall instructions named unst000.exe and unstall.exe. Nothing in the repo has ever produced either; the installer is a WiX MSI that registers an Add or Remove Programs entry. The replacement names this fork's entry and install folder rather than upstream's, which the PR's own wording would have kept wrong. The winget and Chocolatey sections further down that page still describe upstream's packages, which this fork does not publish. Left alone deliberately - what to do about them is a distribution decision, not a documentation fix. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yis for 2026,Yis for 26