fix: widen the icon-only toolbar buttons for thumbs - #185
Merged
Conversation
Measured on an iPhone: Open is 59px wide, Home 81, the star 31 and the copy-link 34. Both new ones clear the WCAG 2.2 AA minimum of 24px, so no gate was going to say anything — but icon-only buttons are the hardest things on that row to hit, and they were the two smallest. min-width 44px, which is the comfortable target size rather than the passing one. Height stays at the row's 38px so they still line up with Open and Home; widths on this row already vary, so nothing looks out of place. Verified at 390px and 320px: both now 44x38, no horizontal scroll, nothing clipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Measured on an iPhone while probing the new toolbar controls:
Both new buttons clear the WCAG 2.2 AA minimum of 24×24, so no gate was ever going to flag them — and the axe e2e passes either way. But icon-only buttons are the hardest things on that row to hit, and they happened to be the two smallest on it.
min-width: 44px— the comfortable target size rather than the passing one. Height stays at the row's 38px so they still line up with Open and Home, and widths on this row already vary, so nothing looks out of place.Not a gate failure, just a thing that was worse than it needed to be.