Fix nested template function depth tracking - #523
Open
674019130 wants to merge 1 commit into
Open
Conversation
|
Thanks for the PR. This appears to match Yaak's contribution policy and is awaiting review by @gschier. This only means the PR is in scope for review. It does not mean the change has been reviewed or accepted for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Count recursive template-function argument evaluation toward the existing render depth budget. This prevents deeply nested function arguments from bypassing
MAX_DEPTH, while preserving normal nesting and the establishedThrowandReturnEmptybehaviors.Root cause
The
Val::Fnargument resolver recursively calledrender_valuewith the unchanged depth. Unlike variable and returned-template recursion, a chain such asf(value=f(value=...))could therefore descend without reaching the guard inrender.Submission
CONTRIBUTING.md.Explicit permission feedback item (required if not a bug fix):
Not required; this is a bug fix.
Related
Verification
cargo test -p yaak-templates— 92 unit tests and all doc tests passedcargo check -p yaak-templatescargo fmt -p yaak-templates -- --checknpm testnpm run lint— passed with two existing TypeScript warnings outside this changeAttribution
Implemented and verified with OpenAI Codex.