Skip to content
This repository was archived by the owner on May 4, 2024. It is now read-only.

Conversation

@macalinao
Copy link
Contributor

Motivation

easier to read

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

WIP

@macalinao
Copy link
Contributor Author

macalinao commented Jul 18, 2022

Incomplete but I'm trying to print strings in Debug-- i need to create some test cases

@macalinao macalinao marked this pull request as draft July 18, 2022 17:22
@sblackshear
Copy link
Member

I think @vgao1996 (who added the VM debug printing logic IIRC), @runtian-zhou, or @tnowacki will be able to suggest a way to test this.

@runtian-zhou
Copy link
Member

I don't have a nice suggestion for testing this at the moment. IIUC the debug printing logic is gated under the testing flag so you definitely can perform a one-shot testing by using --features testing for cargo. I'm not sure how to write a persistent unit test for this. Maybe @vgao1996 may have a better clue?

@vgao1996
Copy link
Member

Sorry for the late reply and I welcome this change!

You can add your new test cases to https://github.com/move-language/move/tree/main/language/tools/move-cli/tests/sandbox_tests/print_values and run env UPBL=1 cargo test to update the .exp files. This should also take care of your existing test failure.

@wrwg
Copy link
Member

wrwg commented Aug 21, 2022

Is this still active?

@macalinao macalinao closed this Sep 2, 2022
@macalinao
Copy link
Contributor Author

Is this still active?

No

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants