Remove use of ament_target_dependencies: Take 2#3726
Open
nbbrooks wants to merge 4 commits into
Open
Conversation
nbbrooks
force-pushed
the
pr-remove-ament-target-dependencies
branch
from
fe0fc9d to
ec8da76
Compare
The previous ament_target_dependencies(... Boost ...) calls implicitly linked every Boost component found by ConfigExtras.cmake (chrono date_time filesystem iostreams program_options regex serialization system thread). Replacing them with target_link_libraries(... Boost::headers) dropped those compiled components, breaking the link step on humble for any TU that uses non-header-only Boost. Add the specific components each target needs: - moveit_test_utils: + Boost::regex (robot_model_test_utils.cpp uses boost::split_regex / boost::regex) - moveit_ompl_interface: + Boost::serialization (detail/constraints_library.hpp uses boost::serialization::map) - moveit_ros_benchmarks: + Boost::filesystem + Boost::regex (BenchmarkExecutor.cpp uses both) Also drop the random_numbers::random_numbers imported target in moveit_kdl_kinematics_plugin -- that target was only added upstream in moveit/random_numbers#47 (merged 2025-05-27, "[kilted]"), so it doesn't exist on jazzy or humble and the CMake configure step fails there. Use the variable form \${random_numbers_LIBRARIES} with a matching target_include_directories so the build works across all supported distros. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Address removal of ament_target_dependencies in ament/ament_cmake#614
Continuation of #3708
Checklist