Skip to content

Conversation

@MarqRazz
Copy link
Contributor

@MarqRazz MarqRazz commented Jun 29, 2021

Description

  • Added panda_hand_controller to the loaded controllers in launch files
  • switched joint_state_controller to joint_state_broadcaster
  • updated visual_tools text to snake case for better readability
  • added collision object example to moveit_cpp tutorial (I am planning on making a PR to remove the demo code from moveit2)

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@MarqRazz MarqRazz requested a review from vatanaksoytezer June 29, 2021 22:26
Copy link
Contributor

@vatanaksoytezer vatanaksoytezer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarqRazz thanks for the PR! I am not sure if we should move to joint_state_broadcaster just before the release today. Maybe we can discuss this change on next moveit standup on when and how to do it.

Rest looks fine and the additional plan is nice! I left a few small nitpicks below. I cannot run this tutorial now correctly, suffering from moveit/moveit2#522. We should at least wait for the fix to get merged in moveit2 before merging this.

@vatanaksoytezer
Copy link
Contributor

Turns out I cannot run because of joint_state_broadcaster is not registered in moveit_resources.

@MarqRazz MarqRazz requested a review from vatanaksoytezer July 1, 2021 22:00
Copy link
Contributor

@vatanaksoytezer vatanaksoytezer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that enormous space is a RVT bug in ROS2. For now I think this is mergable but I think we should look further into it. I suggest we look into it, I will open an issue on this to track progress on this on RVT repo. I run the tutorials without any problems with the latest version of moveit2. Thanks @MarqRazz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants