-
Notifications
You must be signed in to change notification settings - Fork 235
Clean up move_group and moveit_cpp tutorials #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarqRazz thanks for the PR! I am not sure if we should move to joint_state_broadcaster just before the release today. Maybe we can discuss this change on next moveit standup on when and how to do it.
Rest looks fine and the additional plan is nice! I left a few small nitpicks below. I cannot run this tutorial now correctly, suffering from moveit/moveit2#522. We should at least wait for the fix to get merged in moveit2 before merging this.
|
Turns out I cannot run because of |
vatanaksoytezer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that enormous space is a RVT bug in ROS2. For now I think this is mergable but I think we should look further into it. I suggest we look into it, I will open an issue on this to track progress on this on RVT repo. I run the tutorials without any problems with the latest version of moveit2. Thanks @MarqRazz !
Description
panda_hand_controllerto the loaded controllers in launch filesswitchedjoint_state_controllertojoint_state_broadcasterChecklist