Skip to content

Adding tutorial home link melodic#345

Closed
simonGoldstein wants to merge 2 commits intomoveit:melodic-develfrom
PickNikRobotics:Home_link_melodic
Closed

Adding tutorial home link melodic#345
simonGoldstein wants to merge 2 commits intomoveit:melodic-develfrom
PickNikRobotics:Home_link_melodic

Conversation

@simonGoldstein
Copy link
Copy Markdown
Contributor

@simonGoldstein simonGoldstein commented Jun 26, 2019

Description

This is functionally identical to #344 but for the melodic branch.

Most websites have the behavior that if you click on the logo, it returns to the main page of the website. That’s a standard across most websites, and users are used to that. The MoveIt website follows this pattern (on all of the subpages) where if you click the MoveIt logo it returns you to the MoveIt homepage; the one exception, is when you go to the tutorials, which is listed in the MoveIt header navigation, suddenly the behavior changes and clicking on the MoveIt logo does not bring you to the MoveIt website homepage.

This adds that standardized functionality while maintaining the ability to return to the landing page via a new link in the top left.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@simonGoldstein simonGoldstein mentioned this pull request Jun 26, 2019
2 tasks
Copy link
Copy Markdown
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider my additional commits in #344 if accepted there.

@rhaschke
Copy link
Copy Markdown
Contributor

Cherry-picked #344 instead.

@rhaschke rhaschke closed this Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants