Skip to content

fixing the order of the voxels in the image#459

Merged
mamoll merged 2 commits intomoveit:masterfrom
PickNikRobotics:suction-gripper-voxel-order-fixup
Feb 27, 2020
Merged

fixing the order of the voxels in the image#459
mamoll merged 2 commits intomoveit:masterfrom
PickNikRobotics:suction-gripper-voxel-order-fixup

Conversation

@mlautman
Copy link
Copy Markdown
Contributor

@mlautman mlautman commented Feb 21, 2020

Description

Fixes the order of the suction voxels

@mlautman
Copy link
Copy Markdown
Contributor Author

mlautman commented Feb 21, 2020

@Dale-Koenig

@Dale-Koenig
Copy link
Copy Markdown
Contributor

Dale-Koenig commented Feb 22, 2020

I really thing the labeling here should be the same as used by getSuctionVoxel (and therefore 0 indexed). Is there anywhere in the code that starts indexing at 1?

@mlautman
Copy link
Copy Markdown
Contributor Author

mlautman commented Feb 26, 2020

@Dale-Koenig fixed

@mamoll mamoll self-requested a review February 27, 2020 00:07
@mamoll mamoll merged commit 6fec204 into moveit:master Feb 27, 2020
@mamoll mamoll deleted the suction-gripper-voxel-order-fixup branch February 27, 2020 00:08
@Dale-Koenig
Copy link
Copy Markdown
Contributor

Dale-Koenig commented Feb 27, 2020

@Dale-Koenig fixed

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mamoll mamoll mamoll approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mlautman @Dale-Koenig @mamoll