Skip to content

Explain why tutorials must build moveit from source #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Explain why tutorials must build moveit from source #601

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions doc/getting_started/getting_started.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@ Install `wstool <http://wiki.ros.org/wstool>`_ : ::

Create A Catkin Workspace and Download MoveIt Source
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
These tutorials rely on the master branch of MoveIt, which requires a build from source.
You will need to have a `catkin <http://wiki.ros.org/catkin>`_ workspace setup: ::
Because the version of the tutorials uses the ``master`` branch which is being actively developed, you will most likely need to build all of MoveIt from soruce. You will need to have a `catkin <http://wiki.ros.org/catkin>`_ workspace setup: ::

mkdir -p ~/ws_moveit/src
cd ~/ws_moveit/src

wstool init .
wstool merge -t . https://raw.githubusercontent.com/ros-planning/moveit/master/moveit.rosinstall
wstool remove moveit_tutorials # this is clone'd in the next section
Copy link
Member

@JafarAbdi JafarAbdi Mar 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
wstool remove moveit_tutorials # this is clone'd in the next section

Why do we need this line .? isn't the workspace empty

Copy link
Member Author

@davetcoleman davetcoleman Mar 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next section has this line:
git clone https://github.com/ros-planning/moveit_tutorials.git -b master

Which then causes an error. So we could either

  1. Remove it in the next section
  2. Remove it here

I thought this approach was better, because the older versions of the tutorials install moveit from debian, so need this line. So keeping it this way keeps things standard.

However for a beginner, they might think we're crazy and we should remove the second instance of it. Either way is fine with me.

wstool update -t .

Download Example Code
Expand All @@ -53,7 +53,7 @@ The following will install from Debian any package dependencies not already in y

cd ~/ws_moveit/src
rosdep install -y --from-paths . --ignore-src --rosdistro noetic

**Note** In case an upstream package is not (yet) available from the standard ROS repositories or if you experience any build errors in those packages, please try to fetch the latest release candidates from the `ROS testing repositories <http://wiki.ros.org/TestingRepository>`_ instead: ::

sudo sh -c 'echo "deb http://packages.ros.org/ros-testing/ubuntu $(lsb_release -sc) main" > /etc/apt/sources.list.d/ros-latest.list'
Expand Down