Explain why tutorials must build moveit from source #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davetcoleman
force-pushed
the
pr-clarify-source-build
branch
from
09f8038 to
1d41d14
Compare
JafarAbdi
reviewed
Mar 11, 2021
|
|
||
| wstool init . | ||
| wstool merge -t . https://raw.githubusercontent.com/ros-planning/moveit/master/moveit.rosinstall | ||
| wstool remove moveit_tutorials # this is clone'd in the next section |
Member
There was a problem hiding this comment.
Suggested change
| wstool remove moveit_tutorials # this is clone'd in the next section |
Why do we need this line .? isn't the workspace empty
Member
Author
There was a problem hiding this comment.
The next section has this line:
git clone https://github.com/ros-planning/moveit_tutorials.git -b master
Which then causes an error. So we could either
- Remove it in the next section
- Remove it here
I thought this approach was better, because the older versions of the tutorials install moveit from debian, so need this line. So keeping it this way keeps things standard.
However for a beginner, they might think we're crazy and we should remove the second instance of it. Either way is fine with me.
Abishalini
pushed a commit
to Abishalini/moveit_tutorials
that referenced
this pull request
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies this change @rhaschke