[protocol] pcp kurtosis testing - #1
Open
l-monninger wants to merge 36 commits into
Open
Conversation
[ffs-client] post-commitment
l-monninger
commented
Mar 19, 2025
| PostCommitment(PostCommitmentArgs), | ||
| } | ||
|
|
||
| #[derive(clap::Args)] |
Contributor
Author
There was a problem hiding this comment.
Please following the structure of other CLI subcommands, moving this into a separate module.
Contributor
There was a problem hiding this comment.
this PR serves as reference, but may or may not get merged. It still caries information in regards to kurtosis, which is a reason to keep it for now. Most changes on pcp and some client changes have already been merged to main.
| fn verify(&self, error: &alloy_contract::Error) -> Result<bool, PcpEthConnectorError>; | ||
| } | ||
|
|
||
| pub struct SendTransactionErrorRule<Kind> { |
Contributor
Author
There was a problem hiding this comment.
I think you will want to copy over the more recent version of the of MCR structure. This should be under clients/eth.
Contributor
There was a problem hiding this comment.
see previous comment. the mrc structure has been copied over and which is reflected on main
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Categories:
protocol,cliprovide code for kurtosis testing
Changelog
Testing
forge testokOutstanding issues