Qelim fixes#106
Merged
Philipp15b merged 3 commits intomainfrom Dec 19, 2025
Merged
Conversation
Fixes #105. Before, we did qelim with operands that could be infinite. We now disallow that because it leads to unsoundness (see linked issue). Instead of checking that the LHS operand is a constant, we now check that it is finite only. Thus, we now allow expressions with variables inside. As a consequence, quantifier elimination after prob. choices with variables inside now works. I also added support for traversal of the algorithm through parenthesis expressions. Those don't come from vcgen, but only from user-written code.
darionhaase
reviewed
Dec 19, 2025
Member
darionhaase
left a comment
darionhaase
left a comment
There was a problem hiding this comment.
The implemented logic looks good to me. The very basic is_finite check could be improved. But maybe this should be done in a different (future) issue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #105, and fix for another typo. Since this code is pretty easy to get wrong, I'd like a second pair of eyes on the fixes.