This repository was archived by the owner on Nov 3, 2021. It is now read-only.
Bug 875362 - [MMS] Cannot scroll to bottom of thread list as input field... #10803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eld grows r=julienw This patch addresses an issue where the Compose field could grow to completely cover the message thread. Now, a "sliver" of space is reserved to maintain a visual affordance to the underlying thread. This patch also ensures that messages are not occluded while the Thread UI is in "Edit" mode. Previously, the spacing after the final message "bubble" was set to an arbitrary value of 7rem. This patch sets the spacing to the specified amount, and ensures that the spacing remains consistent as the Compose field grows and shrinks (resolving "Bug 882086 - [MMS] [UX] Message thread. Spacing between the last bubble and input field should be 1.5 rem")
Contributor
There was a problem hiding this comment.
Since the name of the variable matches the comment, I would recommend either removing the comment or making it more descriptive: "The vertical margin of the input field".
Contributor
Author
|
pushed as acae7b7 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... grows r=julienw
This patch addresses an issue where the Compose field could grow to
completely cover the message thread. Now, a "sliver" of space is
reserved to maintain a visual affordance to the underlying thread.
This patch also ensures that messages are not occluded while the Thread
UI is in "Edit" mode.
Previously, the spacing after the final message "bubble" was set to an
arbitrary value of 7rem. This patch sets the spacing to the specified
amount, and ensures that the spacing remains consistent as the Compose
field grows and shrinks (resolving "Bug 882086 - [MMS] [UX] Message
thread. Spacing between the last bubble and input field should be 1.5
rem")