Skip to content

Bug 1758000: decode repo.root to str before passing to Path #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cgsheeh merged 2 commits into from
Mar 22, 2022
Merged

Bug 1758000: decode repo.root to str before passing to Path #19

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d7c043
Bug 1758000: decode `repo.root` to `str` before passing to `Path`
cgsheeh Mar 18, 2022
ab6864e
Bug 1758000: use correct `result` key instead of `response`
cgsheeh Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions hgext/differentiator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,23 +21,27 @@


def get_local_repo_callsign(repo) -> str:
"""Returns the callsign from the local repository's `.arcconfig` file."""
repo_path = pathlib.Path(repo.root)
"""Returns the callsign for the local repo parsed from the path.

Uses the repository root path name as the repository ID and returns
the corresponding repository callsign from conduit.
"""
repo_path = pathlib.Path(repo.root.decode("utf-8"))
repo_id = int(repo_path.name)

# Search Conduit for all repositories.
response = call_conduit("diffusion.repository.search", {})

# Retrieve the repo objects.
repo_objects = response["response"]["data"]
repo_objects = response["result"]["data"]

for repo_object in repo_objects:
# If the repo ID we parsed from the working directory matches the
# ID of the current object, return the callsign for this object.
if repo_id == repo_object["id"]:
return repo_object["fields"]["callsign"]

raise error.Abort(b"No repo found with ID %s" % repo_id)
raise error.Abort(b"No repo found with ID %d" % repo_id)


def call_conduit(method: str, params: dict) -> dict:
Expand Down