Deny email registration for Matrix#504
Conversation
Jira: IAM-1617
We already allowed email registrations to Matrix, so we can't disable this connection, since that would break logging in for existing users. That leaves us with only one option: deny at pre-user-registration. Jira: IAM-1617
2a1b3f9 to
339244e
Compare
|
Following-up via Slack with @denschub about if we need to notify anyone, since this would be a breaking change. |
gcoxmoz
left a comment
There was a problem hiding this comment.
I'm not sure I trust my understanding of the explicit code, but I get where you're going enough to think you're on a good path and I don't see anything so scary it shouldn't proceed, so, cautious r+ from me as a reviewer-of-last-resort
skyschub
left a comment
There was a problem hiding this comment.
I don't think we need to do any proactive comms here. We aren't breaking existing users, only new registrations, so I don't think anyone cares. I'll edit the wiki page and keep an eye on our feedback channels, but besides that, I don't see a need to be vocal about this. If I see a lot of complaints, we can put something out.
We already allowed email registrations to Matrix, so we can't disable this
connection, since that would break logging in for existing users.
That leaves us with only one option: deny at pre-user-registration.
Jira: IAM-1617
Plan for
prod