No saved entries (list view)

[ioana-farcas]

Fixes #21

Testing and Review Notes

Note: Pull to refresh should work if there are no entries in the list.

Screenshots or Videos

To Do

• add “WIP” to the PR title if pushing up but not complete nor ready for review
• double check the original issue to confirm it is fully satisfied
• add testing notes and screenshots in PR description to help guide reviewers
• add unit tests
  • optional: consider adding instrumentation (integration/UI) tests
• consider running this branch in a debug simulator and check for memory leak notifications or any warnings
• request the "UX" team perform a design review (if/when applicable)
• make sure CI builds are passing (e.g.: fix lint and other errors)
• check on the accessibility of any added UI

[linuxwolf]

This looks really nice!

The requested change is to remove uncommented code. Otherwise I have nits that are ok to land as-is.

[nickbrandt]

Perfect, nice work! 👍

[devinreams]

Looks good here on Pixel 2 👍

Though there was a long (I connected to a VPN through AUS so accidentally testing a very slow connection) wait with the fully blank screen (no "placeholder" entries in background) and no visual indicator the app is syncing.

I might advocate for looking at this bug soon since I think the state/code/behavior may all be related: #388

[devinreams]

Based on @linuxwolf's code review and @nickbrandt's approval I believe this is good to merge as-is (all three items addressed).

But, we can leave it open for another hour or two in case anyone (else) in @mozilla-lockbox/mobile-engineering would like to take (another) look after our standup.

Thanks for your help on this feature @ioana-farcas 🙇

Code review items have been addressed

[linuxwolf]

r+