This repository was archived by the owner on Dec 14, 2021. It is now read-only.
Merged
Conversation
ghost
assigned
eliserichards
approved these changes
Mar 20, 2019
| sealed class AutofillAction( | ||
| override val eventMethod: TelemetryEventMethod, | ||
| override val eventObject: TelemetryEventObject | ||
| ) : TelemetryAction { |
Contributor
|
@sashei is it easy enough to generate some quick events and @irrationalagent for you to check the pipeline before this gets merged? just to make super sure? I'm happy to merge as-is too and see... |
Contributor
Author
|
@irrationalagent @devinreams sure, I just went thru and did some autofilling and then returned the app to make sure it got uploaded, lmk how that looks for you!! |
Contributor
|
Confirmed new events are good, thanks @irrationalagent @sashei. Merging! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes only getting telemetry for some autofill actions!