Skip to content
This repository was archived by the owner on Dec 14, 2021. It is now read-only.

Replace Welcome FAQ and data usage privacy URLs#424

Merged
devinreams merged 2 commits into172-editing-faqfrom
46-faq-urls
May 29, 2018
Merged

Replace Welcome FAQ and data usage privacy URLs#424
devinreams merged 2 commits into172-editing-faqfrom
46-faq-urls

Conversation

@devinreams
Copy link
Contributor

@devinreams devinreams commented May 23, 2018

Merging into #430

To quadruple check all instances and get the revised anchor links in:

Outside of this PR:

Depends on mozilla-lockwise/mozilla-lockwise.github.io#46

@devinreams devinreams requested a review from a team as a code owner May 23, 2018 14:21
@ghost ghost assigned devinreams May 23, 2018
@ghost ghost added the in progress label May 23, 2018
@devinreams devinreams removed the request for review from a team May 23, 2018 14:21
@devinreams devinreams changed the title (WIP) Replace FAQ URLs Replace FAQ URLs May 23, 2018
@devinreams devinreams added the task Issue describes a task that needs to be completed but is not a defect or enhancement in itself. label May 23, 2018
@sashei
Copy link
Contributor

sashei commented May 23, 2018

I would love to refactor the way we're doing FAQ links from the settings page so that we have only one SettingRouteAction associated.... :p might be out of scope for this story though.

@devinreams
Copy link
Contributor Author

I would love to refactor the way we're doing FAQ links from the settings page so that we have only one SettingRouteAction associated

@sashei Yeah that's fair. Because I now added/proliferated .privacy which really just needs to be another constant URL pulled AFAICT.

I can back out the commit and look at what you have after #430 lands...

@devinreams devinreams changed the base branch from master to 172-editing-faq May 25, 2018 20:58
@devinreams devinreams requested a review from sashei May 25, 2018 21:09
@devinreams
Copy link
Contributor Author

I changed this to just be a ~3 line PR into @sashei's in-progress refactor at #172 #430.

So assuming it's OK then it'll all just go with that PR instead of having to be separate...

@devinreams devinreams changed the title Replace FAQ URLs Replace Welcome FAQ and data usage privacy URLs May 25, 2018
@sashei sashei force-pushed the 172-editing-faq branch from 90917f3 to f3d5108 Compare May 29, 2018 14:22
@ghost ghost assigned sashei May 29, 2018
@sashei sashei removed their assignment May 29, 2018
@devinreams devinreams merged commit aee8770 into 172-editing-faq May 29, 2018
@ghost ghost removed the in progress label May 29, 2018
@devinreams devinreams deleted the 46-faq-urls branch May 29, 2018 18:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

MVP priority-P1 task Issue describes a task that needs to be completed but is not a defect or enhancement in itself.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants