This repository was archived by the owner on Dec 14, 2021. It is now read-only.
Replace Welcome FAQ and data usage privacy URLs#424
Merged
devinreams merged 2 commits into172-editing-faqfrom May 29, 2018
Merged
Replace Welcome FAQ and data usage privacy URLs#424devinreams merged 2 commits into172-editing-faqfrom
devinreams merged 2 commits into172-editing-faqfrom
Conversation
4 tasks
Contributor
|
I would love to refactor the way we're doing FAQ links from the settings page so that we have only one |
Contributor
Author
@sashei Yeah that's fair. Because I now added/proliferated I can back out the commit and look at what you have after #430 lands... |
Contributor
Author
sashei
approved these changes
May 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging into #430
To quadruple check all instances and get the revised anchor links in:
#how-do-i-use-firefox-lockboxprivacy.htmlOutside of this PR:
#how-do-i-enable-sync-on-firefoxhappened at No entries state, prompt for authentication with FxA on other devices (mobile or desktop) to retrieve synced logins #44#how-do-i-edit-existing-entrieshappened at Hook up edit FAQ link at bottom of entry detail #172Depends on mozilla-lockwise/mozilla-lockwise.github.io#46