Untranslated strings not exposed to l10n

[Delphine]

STRs:
Choose any language except English.
Open a website, and then select the menu.
"Add-ons" on top is untranslated.
If you open that submenu, it's all in English.

Seems like these components were never included in the l10n.toml

See also:

• Closes #2799: Add ReaderView L10N comments [ci skip] #2893
• Fail build for components containing string.xml and that are not listed in l10n.toml #1743

(CC @Pike)

┆Issue is synchronized with this Jira Task

[Pike]

I'm wondering if we're winning by naming the components individually, or if we're actually so accustomed to mozac_foo_strings.xml that it's OK to just wildcard in the l10n.toml file?

git status 
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	deleted:    components/support/base/src/main/res/values/strings.xml
	deleted:    components/ui/icons/src/main/res/values/strings.xml
	modified:   l10n.toml

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	components/support/base/src/main/res/values/mozac_support_base_strings.xml
	components/ui/icons/src/main/res/values/mozac_ui_icons_strings.xml

no changes added to commit (use "git add" and/or "git commit -a")

is something I just tested locally.

Gives me ~20 new strings,

compare-locales l10n.toml . fr
components
  browser
    menu/src/main/res/values-fr/strings.xml
        // add and localize this file
    menu2/src/main/res/values-fr/strings.xml
        // add and localize this file
  feature
    contextmenu/src/main/res/values-fr/strings.xml
        -mozac_selection_context_menu_search
        -mozac_selection_context_menu_search_privately
        +mozac_selection_context_menu_search_2
        +mozac_selection_context_menu_search_privately_2
        +mozac_selection_context_menu_email
        +mozac_selection_context_menu_call
    privatemode/src/main/res/values-fr/strings.xml
        // add and localize this file
    prompts/src/main/res/values-fr/strings.xml
        +mozac_feature_prompt_never_save
    pwa/src/main/res/values-fr/strings.xml
        // add and localize this file
    qr/src/main/res/values-fr/strings.xml
        // add and localize this file
    webnotifications/src/main/res/values-fr/strings.xml
        // add and localize this file
  support
    ktx/src/main/res/values-fr/strings.xml
        +mozac_support_ktx_menu_call_with
        +mozac_support_ktx_menu_email_with
    migration/src/main/res/values-fr/strings.xml
        // add and localize this file
fr:
missing          25
missing_w        59
obsolete          2
changed         286
changed_w      1742
unchanged         9
unchanged_w      10

[Amejia481]

@Pike for us will be pretty helpful if we can do a wildcard? Is there any drawback? If not what it's the syntax for it?

[Pike]

I've pushed my local attempt to #7780. Drawback would be that if you have WIP copy, you want to use a different file name than strings.xml.

[Amejia481]

It's not that bad as strings.xml is the standard

[Pike]

This got backed out by an l10n-update landing.