This repository was archived by the owner on Nov 1, 2022. It is now read-only.
  
  
  - 
                Notifications
    
You must be signed in to change notification settings  - Fork 476
 
Closes #2799: Add ReaderView L10N comments [ci skip] #2893
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
          Codecov Report
 @@             Coverage Diff              @@
##             master    #2893      +/-   ##
============================================
- Coverage     81.33%   81.27%   -0.06%     
+ Complexity     3134     3097      -37     
============================================
  Files           398      397       -1     
  Lines         13301    13157     -144     
  Branches       2003     1977      -26     
============================================
- Hits          10819    10694     -125     
+ Misses         1574     1566       -8     
+ Partials        908      897      -11
 Continue to review full report at Codecov. 
  | 
    
              
                    Delphine
  
              
              suggested changes
              
                  
                    May 3, 2019 
                  
              
              
            
            
| 
           @Delphine I've addressed your comments. Could you take one last peek at it again? Thanks!  | 
    
              
                    Delphine
  
              
              approved these changes
              
                  
                    May 7, 2019 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
| 
           Do you want to add readerview to   | 
    
              
                    csadilek
  
              
              approved these changes
              
                  
                    May 7, 2019 
                  
              
              
            
            
          
 Done! :)  | 
    
  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Pull Request checklist