Skip to content
This repository was archived by the owner on Nov 1, 2022. It is now read-only.

Conversation

@jonalmeida
Copy link
Contributor

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@jonalmeida jonalmeida requested a review from csadilek May 1, 2019 13:13
@jonalmeida jonalmeida requested a review from a team as a code owner May 1, 2019 13:13
@jonalmeida jonalmeida changed the title Closes #2799: Add ReaderView L10N comments Closes #2799: Add ReaderView L10N comments [ci skip] May 1, 2019
@jonalmeida jonalmeida requested a review from Delphine May 1, 2019 13:20
@codecov
Copy link

codecov bot commented May 1, 2019

Codecov Report

Merging #2893 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2893      +/-   ##
============================================
- Coverage     81.33%   81.27%   -0.06%     
+ Complexity     3134     3097      -37     
============================================
  Files           398      397       -1     
  Lines         13301    13157     -144     
  Branches       2003     1977      -26     
============================================
- Hits          10819    10694     -125     
+ Misses         1574     1566       -8     
+ Partials        908      897      -11
Impacted Files Coverage Δ Complexity Δ
...components/feature/readerview/ReaderViewFeature.kt 82.75% <0%> (-11.87%) 28% <0%> (-11%)
...mponents/service/glean/private/CommonMetricData.kt 91.66% <0%> (-8.34%) 0% <0%> (ø)
...mponents/service/experiments/ExperimentsUpdater.kt 97.14% <0%> (-2.86%) 7% <0%> (-1%)
...nts/feature/customtabs/CustomTabsToolbarFeature.kt 83.33% <0%> (-2.24%) 23% <0%> (ø)
...la/components/feature/downloads/DownloadManager.kt 83.33% <0%> (-1.67%) 14% <0%> (ø)
...mponents/browser/engine/system/SystemEngineView.kt 78.85% <0%> (-1.15%) 51% <0%> (-6%)
...nents/browser/engine/system/SystemEngineSession.kt 97.1% <0%> (-0.73%) 40% <0%> (-1%)
...nents/service/experiments/KintoExperimentSource.kt 84.37% <0%> (-0.48%) 10% <0%> (-1%)
...illa/components/service/experiments/Experiments.kt 94.91% <0%> (-0.17%) 1% <0%> (ø)
...ain/java/mozilla/components/service/glean/Glean.kt 91.96% <0%> (-0.08%) 1% <0%> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c59c41...866ce07. Read the comment docs.

@jonalmeida
Copy link
Contributor Author

@Delphine I've addressed your comments. Could you take one last peek at it again? Thanks!

@jonalmeida jonalmeida closed this May 6, 2019
@jonalmeida jonalmeida reopened this May 6, 2019
Copy link
Contributor

@Delphine Delphine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@Pike
Copy link
Contributor

Pike commented May 7, 2019

Do you want to add readerview to l10n.toml as part of this issue or should we file a follow-up?

@jonalmeida
Copy link
Contributor Author

Do you want to add readerview to l10n.toml as part of this issue or should we file a follow-up?

Done! :)

@jonalmeida jonalmeida merged commit e6c3bfe into mozilla-mobile:master May 7, 2019
@jonalmeida jonalmeida deleted the issue-2799 branch May 7, 2019 15:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants