Skip to content
This repository was archived by the owner on Nov 1, 2022. It is now read-only.

Issue #12365 - Return an address label based on the available address properties #12366

Merged
merged 2 commits into from
Jun 22, 2022
Merged

Issue #12365 - Return an address label based on the available address properties #12366

merged 2 commits into from
Jun 22, 2022

Conversation

@gabrielluong
Copy link
Member

Fixes #12365.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@gabrielluong gabrielluong added the 🕵️‍♀️ needs review PRs that need to be reviewed label Jun 21, 2022
@gabrielluong gabrielluong requested a review from Amejia481 as a code owner June 21, 2022 17:46
gabrielluong
gabrielluong commented Jun 21, 2022
View reviewed changes
...cept/storage/src/main/java/mozilla/components/concept/storage/CreditCardsAddressesStorage.kt
* priorities defined by the desktop code found here:
* https://searchfox.org/mozilla-central/rev/d989c65584ded72c2de85cb40bede7ac2f176387/toolkit/components/formautofill/FormAutofillUtils.jsm#323
*/
val addressLabel: String
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is uplifted from Fenix mozilla-mobile/fenix#25039.

Alexandru2909
Alexandru2909 reviewed Jun 22, 2022
View reviewed changes
...ature/prompts/src/test/java/mozilla/components/feature/prompts/address/AddressAdapterTest.kt
@@ -1,3 +1,6 @@
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this!

@gabrielluong gabrielluong added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Jun 22, 2022
@mergify mergify bot merged commit ff265b5 into mozilla-mobile:main Jun 22, 2022
@gabrielluong gabrielluong deleted the 12365 branch June 22, 2022 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Amejia481 Amejia481 Awaiting requested review from Amejia481

1 more reviewer

@Alexandru2909 Alexandru2909 Alexandru2909 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🛬 needs landing PRs that are ready to land

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Align the address label in the select address prompt with Fenix

2 participants

@gabrielluong @Alexandru2909